Add lint info to Async #5956
Merged
Add lint info to Async #5956
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Visit the preview URL for this PR (updated for commit 8b3f113): |
| * [discarded_futures][] | ||
| * [unawaited_futures][] | ||
|
|
||
| By default, these lints aren't enabled. |
There was a problem hiding this comment.
No lints are enabled by default. This sentence is unnecessary.
atsansone
commented
Jul 3, 2024
|
@MaryaBelanger : PTAL. |
|
I like Marya's point with positioning the lints closer to the beginning! Since it's positioned right before "Congratulations!" it shows up after when it would be useful to the reader. |
|
/gcbrun |
Co-authored-by: Marya <111139605+MaryaBelanger@users.noreply.github.com>
Co-authored-by: Marya <111139605+MaryaBelanger@users.noreply.github.com>
|
@khanhnwin : Fixed. |
|
@khanhnwin : PTAL. |
khanhnwin
reviewed
Jul 18, 2024
atsansone
commented
Jul 18, 2024
khanhnwin
approved these changes
Jul 18, 2024
|
@atsansone I think there is some merge conflict in |
Merged
|
Thanks for the heads up @stephane-archer! I just opened https://github.com/dart-lang/site-www/pull/5984/files to remove those merge conflict artifacts! |
atsansone
pushed a commit
that referenced
this pull request
Jul 19, 2024
remove merge conflict artifacts as noted in: #5956 (comment)
|
@khanhnwin I'm glad to help :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5740