Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify renames section on package:web page #5676

Merged
merged 3 commits into from
Apr 2, 2024
Merged

Clarify renames section on package:web page #5676

merged 3 commits into from
Apr 2, 2024

Conversation

MaryaBelanger
Copy link
Contributor

Fixes #5601

@MaryaBelanger MaryaBelanger requested a review from srujzs April 1, 2024 20:57
@dart-github-bot
Copy link
Collaborator

dart-github-bot commented Apr 1, 2024 •
edited
Loading

Visit the preview URL for this PR (updated for commit 6ab64c0):

https://dart-dev--pr5676-revise-pkgweb-njtf3owr.web.app

srujzs
srujzs approved these changes Apr 1, 2024
View reviewed changes
Copy link
Contributor

@srujzs srujzs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

There are maybe a handful of members we rename in package:web because they use the same name as unshadowable language keywords, but it's not worth mentioning here as that would lead to unnecessary confusion.

@MaryaBelanger MaryaBelanger merged commit cc7d172 into main Apr 2, 2024
9 checks passed
@kevmoo kevmoo deleted the revise-pkgweb branch August 20, 2024 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@parlough parlough parlough approved these changes

@srujzs srujzs srujzs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Clarify package:web migration text
4 participants
@MaryaBelanger @dart-github-bot @parlough @srujzs