Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix and standardize various links in JS interop docs #5667

Merged
merged 1 commit into from
Mar 29, 2024

Conversation

parlough
Copy link
Member

  • Don't link to dev version of API docs
  • Use site variables where possible
  • Don't link to en-US MDN docs, so the site can choose the appropriate locale for the user

@dart-github-bot
Copy link
Collaborator

Visit the preview URL for this PR (updated for commit 4996fc8):

https://dart-dev--pr5667-fix-js-interop-links-67me7cgt.web.app

Copy link
Contributor

@MaryaBelanger MaryaBelanger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much Parker!

@MaryaBelanger MaryaBelanger merged commit a3f67c0 into main Mar 29, 2024
9 checks passed
@MaryaBelanger MaryaBelanger deleted the fix/js-interop-links branch March 29, 2024 18:50
@kevmoo
Copy link
Member

kevmoo commented Mar 29, 2024

Bless you, kind sir. 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants