Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update set up instructions and pnpm dependencies #5531

Merged
merged 1 commit into from
Feb 12, 2024
Merged

Conversation

parlough
Copy link
Member

Updated the README to make it clear that corepack is not required, it's just an easy way to install pnpm and match the version required by the current project.

Also update default pnpm version and various transitive dependencies, including some fixes for 11ty dev server.

@dart-github-bot
Copy link
Collaborator

Visit the preview URL for this PR (updated for commit a997215):

https://dart-dev--pr5531-misc-pnpm-updates-xa2buv6g.web.app

Copy link
Contributor

@atsansone atsansone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Would it be worth having more that covers if you already have other versions of node or npm installed? We saw what happened when that's the case. It doesn't have to be in this PR, though.

@parlough
Copy link
Member Author

Thanks for the review!

Having other versions of node or npm isn't a problem. It's just the person needs to update the version they use. It's always a problem to have differing installs of a program. I added a section in a previous PR to explain this, including checking your current Node version first.

@parlough parlough merged commit 6ed6f09 into main Feb 12, 2024
8 checks passed
@parlough parlough deleted the misc/pnpm-updates branch February 12, 2024 21:59
@parlough parlough removed the st.RFM label Feb 12, 2024
atsansone pushed a commit to atsansone/site-www that referenced this pull request Feb 20, 2024
Updated the README to make it clear that `corepack` is not required,
it's just an easy way to install `pnpm` and match the version required
by the current project.

Also update default pnpm version and various transitive dependencies,
including some fixes for 11ty dev server.
atsansone pushed a commit to atsansone/site-www that referenced this pull request Mar 22, 2024
Updated the README to make it clear that `corepack` is not required,
it's just an easy way to install `pnpm` and match the version required
by the current project.

Also update default pnpm version and various transitive dependencies,
including some fixes for 11ty dev server.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants