Merge null_safety_examples with examples (#3398)

Author: parlough

.github/workflows/build.yml

@@ -30,27 +30,17 @@ jobs:
         task:
           - ./tool/build.sh --check-links
           - ./tool/check-code.sh
-          - ./tool/check-code.sh --null-safety
         experimental: [false]
         include:
           - sdk: dev
             task: ./tool/analyze-and-test-examples.sh
-            experimental: true
+            experimental: false
           - sdk: beta
             task: ./tool/analyze-and-test-examples.sh
-            experimental: true
+            experimental: false
           - sdk: stable
             task: ./tool/analyze-and-test-examples.sh
             experimental: false
-          - sdk: dev
-            task: ./tool/analyze-and-test-examples.sh --null-safety
-            experimental: true
-          - sdk: beta
-            task: ./tool/analyze-and-test-examples.sh --null-safety
-            experimental: true
-          - sdk: stable
-            task: ./tool/analyze-and-test-examples.sh --null-safety
-            experimental: true
     steps:
       - uses: actions/checkout@v2
         with:

build.excerpt.yaml

@@ -3,7 +3,6 @@ targets:
     sources:
       include:
         - 'examples/**'
-        - 'null_safety_examples/**'
         # Some default includes that aren't really used here but will prevent
         # false-negative warnings:
         - $package$

null_safety_examples/analysis/analysis_options.yaml examples/analysis/analysis_options.yaml

@@ -0,0 +1,7 @@
+Analyzing analysis...
+
+  error - lib/assignment.dart:11:14 - A value of type 'dynamic' can't be assigned to a variable of type 'String'. Try changing the type of the variable, or casting the right-hand type to 'String'. - invalid_assignment
+   info - lib/lint.dart:9:19 - Avoid empty statements. - empty_statements
+   info - lib/lint.dart:17:7 - Close instances of `dart.core.Sink`. - close_sinks
+
+3 issues found.

examples/analysis/analyzer-results-beta.txt

@@ -0,0 +1,7 @@
+Analyzing analysis...
+
+  error - lib/assignment.dart:11:14 - A value of type 'dynamic' can't be assigned to a variable of type 'String'. Try changing the type of the variable, or casting the right-hand type to 'String'. - invalid_assignment
+   info - lib/lint.dart:9:19 - Avoid empty statements. - empty_statements
+   info - lib/lint.dart:17:7 - Close instances of `dart.core.Sink`. - close_sinks
+
+3 issues found.

examples/analysis/analyzer-results-dev.txt

@@ -0,0 +1,7 @@
+Analyzing analysis...
+
+  error - lib/assignment.dart:11:14 - A value of type 'dynamic' can't be assigned to a variable of type 'String'. Try changing the type of the variable, or casting the right-hand type to 'String'. - invalid_assignment
+   info - lib/lint.dart:9:19 - Avoid empty statements. - empty_statements
+   info - lib/lint.dart:17:7 - Close instances of `dart.core.Sink`. - close_sinks
+
+3 issues found.

examples/analysis/analyzer-results-stable.txt

@@ -1,4 +1,4 @@
-name: null_safety_examples_basics
+name: basics_examples
 description: dart.dev null-safety examples.
 version: 0.0.1
 

null_safety_examples/analysis/lib/assignment.dart examples/analysis/lib/assignment.dart

@@ -1,4 +1,4 @@
-name: create_libraries
+name: extension_methods_examples
 description: dart.dev example code.
 version: 1.0.0
 

null_safety_examples/analysis/lib/lint.dart examples/analysis/lib/lint.dart

@@ -1,4 +1,4 @@
-name: fetch_data_example
+name: fetch_data_examples
 description: Fetch data example
 version: 0.0.1
 

null_safety_examples/analysis/pubspec.yaml examples/analysis/pubspec.yaml

@@ -1,4 +1,4 @@
-name: html_library_sample
+name: html_library_examples
 description: dart.dev example code.
 version: 0.0.1
 

null_safety_examples/analysis_alt/analysis_options.yaml examples/analysis_alt/analysis_options.yaml

@@ -1,4 +1,4 @@
-name: iterables
+name: iterables_examples
 description: dart.dev example code.
 
 environment:

null_safety_examples/analysis_alt/analysis_options_linter.yaml examples/analysis_alt/analysis_options_linter.yaml

@@ -0,0 +1,7 @@
+Analyzing misc...
+
+   info - lib/effective_dart/usage_good.dart:481:9 - Use initializing formals when possible. - prefer_initializing_formals
+   info - lib/language_tour/metadata/television.dart:4:3 - Provide a deprecation message, via @Deprecated("message"). - provide_deprecation_message
+  error - lib/library_tour/core/collections.dart:5:14 - The argument type 'int' can't be assigned to the parameter type 'String'. - argument_type_not_assignable
+
+3 issues found.

null_safety_examples/analysis_alt/pubspec.yaml examples/analysis_alt/pubspec.yaml

@@ -0,0 +1,7 @@
+Analyzing misc...
+
+   info - lib/effective_dart/usage_good.dart:481:9 - Use initializing formals when possible. - prefer_initializing_formals
+   info - lib/language_tour/metadata/television.dart:4:3 - Provide a deprecation message, via @Deprecated("message"). - provide_deprecation_message
+  error - lib/library_tour/core/collections.dart:5:14 - The argument type 'int' can't be assigned to the parameter type 'String'. - argument_type_not_assignable
+
+3 issues found.

null_safety_examples/analysis_options.yaml examples/analysis_options.yaml

@@ -0,0 +1,8 @@
+Analyzing misc...
+
+   info - lib/effective_dart/usage_good.dart:461:26 - Use initializing formals when possible. - prefer_initializing_formals
+   info - lib/effective_dart/usage_good.dart:481:9 - Use initializing formals when possible. - prefer_initializing_formals
+   info - lib/language_tour/metadata/television.dart:4:3 - Provide a deprecation message, via @Deprecated("message"). - provide_deprecation_message
+  error - lib/library_tour/core/collections.dart:5:14 - The argument type 'int' can't be assigned to the parameter type 'String'. - argument_type_not_assignable
+
+4 issues found.

null_safety_examples/async_await/analysis_options.yaml examples/async_await/analysis_options.yaml

@@ -3,7 +3,8 @@ class Spacecraft {
   String name;
   DateTime? launchDate;
 
-  int? get launchYear => launchDate?.year; // read-only non-final property
+  // Read-only non-final property
+  int? get launchYear => launchDate?.year;
 
   // Constructor, with syntactic sugar for assignment to members.
   Spacecraft(this.name, this.launchDate) {
@@ -16,9 +17,11 @@ class Spacecraft {
   // Method.
   void describe() {
     print('Spacecraft: $name');
-    var launchDate = this.launchDate; // Type promotion doesn't work on getters.
+    // Type promotion doesn't work on getters.
+    var launchDate = this.launchDate;
     if (launchDate != null) {
-      int years = DateTime.now().difference(launchDate).inDays ~/ 365;
+      int years =
+          DateTime.now().difference(launchDate).inDays ~/ 365;
       print('Launched: $launchYear ($years years ago)');
     } else {
       print('Unlaunched');
@@ -49,8 +52,9 @@ mixin Piloted {
 // #docregion mixin-use
 class PilotedCraft extends Spacecraft with Piloted {
   // #enddocregion mixin-use
-  PilotedCraft(String name, DateTime launchDate) : super(name, launchDate);
-// #docregion mixin-use
+  PilotedCraft(String name, DateTime launchDate)
+      : super(name, launchDate);
+  // #docregion mixin-use
 }
 // #enddocregion mixin-use
 
@@ -70,7 +74,7 @@ class MockSpaceship implements Spacecraft {
 
   @override
   void describe() => print(name);
-// #docregion implements
+  // #docregion implements
 }
 // #enddocregion implements
 

null_safety_examples/async_await/bin/async_example.dart examples/async_await/bin/async_example.dart

@@ -89,7 +89,8 @@ void main() {
   });
 
   test('employee', () {
-    expect(employee.main, m.prints(['in Person', 'in Employee']));
+    expect(employee.main,
+        m.prints(['in Person', 'in Employee', "Instance of 'Employee'"]));
   });
 
   test('point_with_distance', () {

null_safety_examples/async_await/bin/futures_intro.dart examples/async_await/bin/futures_intro.dart

@@ -81,7 +81,8 @@ void main() {
   });
 
   test('is-vs-as', () {
-    expect(employee.main, m.prints(['in Person', 'in Employee']));
+    expect(employee.main,
+        m.prints(['in Person', 'in Employee', "Instance of 'Employee'"]));
   });
 
   group('`=` vs `??=`:', () {

null_safety_examples/async_await/bin/get_order.dart examples/async_await/bin/get_order.dart

@@ -16,7 +16,7 @@ void main() {
   });
 
   test('strings', () {
-    expect(strings.main, prints(endsWith('tau is 6.28\n')));
+    expect(strings.main, prints(contains('tau is 6.28')));
   });
 
   test('collection_literals', () {

null_safety_examples/async_await/bin/get_order_sync_bad.dart examples/async_await/bin/get_order_sync_bad.dart

@@ -1,4 +1,4 @@
-name: non_promotion
+name: non_promotion_examples
 description: dart.dev non-promotion examples.
 version: 0.0.1
 

null_safety_examples/async_await/bin/try_catch.dart examples/async_await/bin/try_catch.dart

@@ -1,4 +1,4 @@
-name: null_safety_codelab
+name: null_safety_codelab_examples
 description: dart.dev example code for null safety codelab
 
 environment:

null_safety_examples/async_await/dart_test.yaml examples/async_await/dart_test.yaml

@@ -1,8 +1,8 @@
-Analyzing strong...
+Analyzing type_system...
 
   error - lib/bounded/instantiate_to_bound.dart:7:5 - The method 'add' isn't defined for the type 'Iterable'. Try correcting the name to the name of an existing method, or defining a method named 'add'. - undefined_method
-  error - lib/common_fixes_analysis.dart:15:12 - The getter 'context2D' isn't defined for the type 'Element'. Try importing the library that defines 'context2D', correcting the name to the name of an existing getter, or defining a getter or field named 'context2D'. - undefined_getter
-  error - lib/common_fixes_analysis.dart:38:16 - A value of type 'double' can't be assigned to a variable of type 'int'. Try changing the type of the variable, or casting the right-hand type to 'int'. - invalid_assignment
+  error - lib/common_fixes_analysis.dart:16:12 - The getter 'context2D' isn't defined for the type 'Element'. Try importing the library that defines 'context2D', correcting the name to the name of an existing getter, or defining a getter or field named 'context2D'. - undefined_getter
+  error - lib/common_fixes_analysis.dart:39:16 - A value of type 'double' can't be assigned to a variable of type 'int'. Try changing the type of the variable, or casting the right-hand type to 'int'. - invalid_assignment
   error - lib/common_fixes_analysis.dart:61:7 - 'MyAdder.add' ('num Function(int, int)') isn't a valid override of 'NumberAdder.add' ('num Function(num, num)'). - invalid_override
   error - lib/common_fixes_analysis.dart:80:8 - 'Subclass.method' ('void Function(int)') isn't a valid override of 'Superclass.method' ('void Function(dynamic)'). - invalid_override
   error - lib/common_fixes_analysis.dart:97:9 - The superclass call must be last in an initializer list: 'super(food)'. - invalid_super_invocation
@@ -15,8 +15,6 @@ Analyzing strong...
   error - lib/strong_analysis.dart:107:23 - A value of type 'String' can't be assigned to a variable of type 'double'. Try changing the type of the variable, or casting the right-hand type to 'double'. - invalid_assignment
   error - lib/strong_analysis.dart:119:19 - A value of type 'Cat' can't be assigned to a variable of type 'MaineCoon'. Try changing the type of the variable, or casting the right-hand type to 'MaineCoon'. - invalid_assignment
   error - lib/strong_analysis.dart:144:24 - A value of type 'List<Animal>' can't be assigned to a variable of type 'List<Cat>'. Try changing the type of the variable, or casting the right-hand type to 'List<Cat>'. - invalid_assignment
-  error - test/strong_test.dart:36:27 - A value of type 'List<dynamic>' can't be assigned to a variable of type 'List<int>'. Try changing the type of the variable, or casting the right-hand type to 'List<int>'. - invalid_assignment
-  error - test/strong_test.dart:53:26 - A value of type 'List<Animal>' can't be assigned to a variable of type 'List<Cat>'. Try changing the type of the variable, or casting the right-hand type to 'List<Cat>'. - invalid_assignment
-  error - test/strong_test.dart:158:26 - A value of type 'dynamic' can't be assigned to a variable of type 'List<String>'. Try changing the type of the variable, or casting the right-hand type to 'List<String>'. - invalid_assignment
+  error - test/strong_test.dart:120:26 - A value of type 'dynamic' can't be assigned to a variable of type 'List<String>'. Try changing the type of the variable, or casting the right-hand type to 'List<String>'. - invalid_assignment
 
-18 issues found.
+16 issues found.

null_safety_examples/async_await/pubspec.yaml examples/async_await/pubspec.yaml

@@ -1,8 +1,8 @@
-Analyzing strong...
+Analyzing type_system...
 
   error - lib/bounded/instantiate_to_bound.dart:7:5 - The method 'add' isn't defined for the type 'Iterable'. Try correcting the name to the name of an existing method, or defining a method named 'add'. - undefined_method
-  error - lib/common_fixes_analysis.dart:15:12 - The getter 'context2D' isn't defined for the type 'Element'. Try importing the library that defines 'context2D', correcting the name to the name of an existing getter, or defining a getter or field named 'context2D'. - undefined_getter
-  error - lib/common_fixes_analysis.dart:38:16 - A value of type 'double' can't be assigned to a variable of type 'int'. Try changing the type of the variable, or casting the right-hand type to 'int'. - invalid_assignment
+  error - lib/common_fixes_analysis.dart:16:12 - The getter 'context2D' isn't defined for the type 'Element'. Try importing the library that defines 'context2D', correcting the name to the name of an existing getter, or defining a getter or field named 'context2D'. - undefined_getter
+  error - lib/common_fixes_analysis.dart:39:16 - A value of type 'double' can't be assigned to a variable of type 'int'. Try changing the type of the variable, or casting the right-hand type to 'int'. - invalid_assignment
   error - lib/common_fixes_analysis.dart:61:7 - 'MyAdder.add' ('num Function(int, int)') isn't a valid override of 'NumberAdder.add' ('num Function(num, num)'). - invalid_override
   error - lib/common_fixes_analysis.dart:80:8 - 'Subclass.method' ('void Function(int)') isn't a valid override of 'Superclass.method' ('void Function(dynamic)'). - invalid_override
   error - lib/common_fixes_analysis.dart:97:9 - The superclass call must be last in an initializer list: 'super(food)'. - invalid_super_invocation
@@ -15,8 +15,6 @@ Analyzing strong...
   error - lib/strong_analysis.dart:107:23 - A value of type 'String' can't be assigned to a variable of type 'double'. Try changing the type of the variable, or casting the right-hand type to 'double'. - invalid_assignment
   error - lib/strong_analysis.dart:119:19 - A value of type 'Cat' can't be assigned to a variable of type 'MaineCoon'. Try changing the type of the variable, or casting the right-hand type to 'MaineCoon'. - invalid_assignment
   error - lib/strong_analysis.dart:144:24 - A value of type 'List<Animal>' can't be assigned to a variable of type 'List<Cat>'. Try changing the type of the variable, or casting the right-hand type to 'List<Cat>'. - invalid_assignment
-  error - test/strong_test.dart:36:27 - A value of type 'List<dynamic>' can't be assigned to a variable of type 'List<int>'. Try changing the type of the variable, or casting the right-hand type to 'List<int>'. - invalid_assignment
-  error - test/strong_test.dart:53:26 - A value of type 'List<Animal>' can't be assigned to a variable of type 'List<Cat>'. Try changing the type of the variable, or casting the right-hand type to 'List<Cat>'. - invalid_assignment
-  error - test/strong_test.dart:158:26 - A value of type 'dynamic' can't be assigned to a variable of type 'List<String>'. Try changing the type of the variable, or casting the right-hand type to 'List<String>'. - invalid_assignment
+  error - test/strong_test.dart:120:26 - A value of type 'dynamic' can't be assigned to a variable of type 'List<String>'. Try changing the type of the variable, or casting the right-hand type to 'List<String>'. - invalid_assignment
 
-18 issues found.
+16 issues found.

null_safety_examples/async_await/test/async_await_test.dart examples/async_await/test/async_await_test.dart

@@ -1,8 +1,8 @@
-Analyzing strong...
+Analyzing type_system...
 
   error - lib/bounded/instantiate_to_bound.dart:7:5 - The method 'add' isn't defined for the type 'Iterable'. Try correcting the name to the name of an existing method, or defining a method named 'add'. - undefined_method
-  error - lib/common_fixes_analysis.dart:15:12 - The getter 'context2D' isn't defined for the type 'Element'. Try importing the library that defines 'context2D', correcting the name to the name of an existing getter, or defining a getter or field named 'context2D'. - undefined_getter
-  error - lib/common_fixes_analysis.dart:38:16 - A value of type 'double' can't be assigned to a variable of type 'int'. Try changing the type of the variable, or casting the right-hand type to 'int'. - invalid_assignment
+  error - lib/common_fixes_analysis.dart:16:12 - The getter 'context2D' isn't defined for the type 'Element'. Try importing the library that defines 'context2D', correcting the name to the name of an existing getter, or defining a getter or field named 'context2D'. - undefined_getter
+  error - lib/common_fixes_analysis.dart:39:16 - A value of type 'double' can't be assigned to a variable of type 'int'. Try changing the type of the variable, or casting the right-hand type to 'int'. - invalid_assignment
   error - lib/common_fixes_analysis.dart:61:7 - 'MyAdder.add' ('num Function(int, int)') isn't a valid override of 'NumberAdder.add' ('num Function(num, num)'). - invalid_override
   error - lib/common_fixes_analysis.dart:80:8 - 'Subclass.method' ('void Function(int)') isn't a valid override of 'Superclass.method' ('void Function(dynamic)'). - invalid_override
   error - lib/common_fixes_analysis.dart:97:9 - The superclass call must be last in an initializer list: 'super(food)'. - invalid_super_invocation
@@ -15,8 +15,6 @@ Analyzing strong...
   error - lib/strong_analysis.dart:107:23 - A value of type 'String' can't be assigned to a variable of type 'double'. Try changing the type of the variable, or casting the right-hand type to 'double'. - invalid_assignment
   error - lib/strong_analysis.dart:119:19 - A value of type 'Cat' can't be assigned to a variable of type 'MaineCoon'. Try changing the type of the variable, or casting the right-hand type to 'MaineCoon'. - invalid_assignment
   error - lib/strong_analysis.dart:144:24 - A value of type 'List<Animal>' can't be assigned to a variable of type 'List<Cat>'. Try changing the type of the variable, or casting the right-hand type to 'List<Cat>'. - invalid_assignment
-  error - test/strong_test.dart:36:27 - A value of type 'List<dynamic>' can't be assigned to a variable of type 'List<int>'. Try changing the type of the variable, or casting the right-hand type to 'List<int>'. - invalid_assignment
-  error - test/strong_test.dart:53:26 - A value of type 'List<Animal>' can't be assigned to a variable of type 'List<Cat>'. Try changing the type of the variable, or casting the right-hand type to 'List<Cat>'. - invalid_assignment
-  error - test/strong_test.dart:158:26 - A value of type 'dynamic' can't be assigned to a variable of type 'List<String>'. Try changing the type of the variable, or casting the right-hand type to 'List<String>'. - invalid_assignment
+  error - test/strong_test.dart:120:26 - A value of type 'dynamic' can't be assigned to a variable of type 'List<String>'. Try changing the type of the variable, or casting the right-hand type to 'List<String>'. - invalid_assignment
 
-18 issues found.
+16 issues found.

null_safety_examples/basics/analysis_options.yaml examples/basics/analysis_options.yaml

@@ -1,4 +1,4 @@
-name: examples_strong
+name: type_system_examples
 description: dart.dev type system examples.
 
 environment:

null_safety_examples/basics/lib/late.dart examples/basics/lib/late.dart

@@ -1,8 +1,8 @@
 // ignore_for_file: unused_local_variable, strict_raw_type
 import 'package:test/test.dart';
 
-import 'package:examples_strong/animal.dart';
-import 'package:examples_strong/bounded/my_collection.dart';
+import 'package:type_system_examples/animal.dart';
+import 'package:type_system_examples/bounded/my_collection.dart';
 
 Matcher _throwsA<T>(String msg) => throwsA(
       allOf(
@@ -116,7 +116,7 @@ void main() {
 
 // #docregion downcast-check
 void assumeStrings(dynamic objects) {
-  // ignore_for_file: invalid_assignment
+  // ignore_for_file: stable, beta, dev, invalid_assignment
   List<String> strings = objects; // Runtime downcast check
   String string = strings[0]; // Expect a String value
   // #enddocregion downcast-check