Skip to content

Commit 272d104

Browse files
authored
Simplify tool pubspec setup (#4959)
We had a separate pubspec in the `/tool` directory, potentially causing issues depending on where you ran `dart pub get` previously. This simplifies to just using the pubspec in the root directory where you'll run related commands. Once this lands in your branch, you'll need to rerun `make setup` to get the tool commands working. Closes #4955
1 parent 6ae3131 commit 272d104

File tree

3 files changed

+4
-13
lines changed

3 files changed

+4
-13
lines changed

pubspec.yaml

+2
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
name: site_www
2+
publish_to: none
23

34
homepage: https://dart.dev
45

@@ -13,4 +14,5 @@ dev_dependencies:
1314
path: site-shared/packages/code_excerpter
1415
linkcheck: ^3.0.0
1516
lints: ^2.1.0
17+
logging: ^1.2.0
1618
path: ^1.8.3

tool/check-links.sh

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
#!/usr/bin/env bash
22
# Check for non-200 links in built Jekyll site using Firebase emulator
3-
set -eu -o pipefail
3+
set -eu -o pipefail
44
source $TOOL_DIR/utils.sh
55

66
dart pub get
@@ -33,7 +33,7 @@ sleep 3
3333
if [[ -z "$emulator_status" ]]; then
3434
echo -e "$(red "Emulator did not start...")"
3535
exit 1
36-
else
36+
else
3737
echo -e "$(blue "Emulator is running")"
3838
fi
3939

tool/pubspec.yaml

-11
This file was deleted.

0 commit comments

Comments
 (0)