Skip to content

Commit 777996f

Browse files
authored
Update CI and lints for Dart 3.4 release (#221)
1 parent e466136 commit 777996f

File tree

8 files changed

+33
-30
lines changed

8 files changed

+33
-30
lines changed

.github/workflows/dart.yml

+10-10
Original file line numberDiff line numberDiff line change
@@ -39,23 +39,23 @@ jobs:
3939
- name: mono_repo self validate
4040
run: dart pub global run mono_repo generate --validate
4141
job_002:
42-
name: "analyzer_and_format; Dart 3.3.0; PKGS: packages/code_excerpt_updater, packages/code_excerpter, packages/excerpter, packages/inject_dartpad; `dart format --output=none --set-exit-if-changed .`, `dart analyze --fatal-infos .`"
42+
name: "analyzer_and_format; Dart 3.4.0; PKGS: packages/code_excerpt_updater, packages/code_excerpter, packages/excerpter, packages/inject_dartpad; `dart format --output=none --set-exit-if-changed .`, `dart analyze --fatal-infos .`"
4343
runs-on: ubuntu-latest
4444
steps:
4545
- name: Cache Pub hosted dependencies
4646
uses: actions/cache@0c45773b623bea8c8e75f6c82b208c3cf94ea4f9
4747
with:
4848
path: "~/.pub-cache/hosted"
49-
key: "os:ubuntu-latest;pub-cache-hosted;sdk:3.3.0;packages:packages/code_excerpt_updater-packages/code_excerpter-packages/excerpter-packages/inject_dartpad;commands:format-analyze"
49+
key: "os:ubuntu-latest;pub-cache-hosted;sdk:3.4.0;packages:packages/code_excerpt_updater-packages/code_excerpter-packages/excerpter-packages/inject_dartpad;commands:format-analyze"
5050
restore-keys: |
51-
os:ubuntu-latest;pub-cache-hosted;sdk:3.3.0;packages:packages/code_excerpt_updater-packages/code_excerpter-packages/excerpter-packages/inject_dartpad
52-
os:ubuntu-latest;pub-cache-hosted;sdk:3.3.0
51+
os:ubuntu-latest;pub-cache-hosted;sdk:3.4.0;packages:packages/code_excerpt_updater-packages/code_excerpter-packages/excerpter-packages/inject_dartpad
52+
os:ubuntu-latest;pub-cache-hosted;sdk:3.4.0
5353
os:ubuntu-latest;pub-cache-hosted
5454
os:ubuntu-latest
5555
- name: Setup Dart SDK
5656
uses: dart-lang/setup-dart@f0ead981b4d9a35b37f30d36160575d60931ec30
5757
with:
58-
sdk: "3.3.0"
58+
sdk: "3.4.0"
5959
- id: checkout
6060
name: Checkout repository
6161
uses: actions/checkout@44c2b7a8a4ea60a981eaca3cf939b5f4305c123b
@@ -185,23 +185,23 @@ jobs:
185185
if: "always() && steps.packages_inject_dartpad_pub_upgrade.conclusion == 'success'"
186186
working-directory: packages/inject_dartpad
187187
job_004:
188-
name: "unit_test; Dart 3.3.0; PKGS: packages/code_excerpt_updater, packages/code_excerpter, packages/excerpter; `dart test`"
188+
name: "unit_test; Dart 3.4.0; PKGS: packages/code_excerpt_updater, packages/code_excerpter, packages/excerpter; `dart test`"
189189
runs-on: ubuntu-latest
190190
steps:
191191
- name: Cache Pub hosted dependencies
192192
uses: actions/cache@0c45773b623bea8c8e75f6c82b208c3cf94ea4f9
193193
with:
194194
path: "~/.pub-cache/hosted"
195-
key: "os:ubuntu-latest;pub-cache-hosted;sdk:3.3.0;packages:packages/code_excerpt_updater-packages/code_excerpter-packages/excerpter;commands:test"
195+
key: "os:ubuntu-latest;pub-cache-hosted;sdk:3.4.0;packages:packages/code_excerpt_updater-packages/code_excerpter-packages/excerpter;commands:test"
196196
restore-keys: |
197-
os:ubuntu-latest;pub-cache-hosted;sdk:3.3.0;packages:packages/code_excerpt_updater-packages/code_excerpter-packages/excerpter
198-
os:ubuntu-latest;pub-cache-hosted;sdk:3.3.0
197+
os:ubuntu-latest;pub-cache-hosted;sdk:3.4.0;packages:packages/code_excerpt_updater-packages/code_excerpter-packages/excerpter
198+
os:ubuntu-latest;pub-cache-hosted;sdk:3.4.0
199199
os:ubuntu-latest;pub-cache-hosted
200200
os:ubuntu-latest
201201
- name: Setup Dart SDK
202202
uses: dart-lang/setup-dart@f0ead981b4d9a35b37f30d36160575d60931ec30
203203
with:
204-
sdk: "3.3.0"
204+
sdk: "3.4.0"
205205
- id: checkout
206206
name: Checkout repository
207207
uses: actions/checkout@44c2b7a8a4ea60a981eaca3cf939b5f4305c123b

packages/analysis_defaults/lib/analysis.yaml

+1
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@ linter:
1414
- implicit_reopen
1515
- invalid_case_patterns
1616
- matching_super_parameters
17+
- missing_code_block_language_in_doc_comment
1718
- no_literal_bool_comparisons
1819
- no_self_assignments
1920
- package_api_docs

packages/analysis_defaults/pubspec.yaml

+2-2
Original file line numberDiff line numberDiff line change
@@ -3,9 +3,9 @@ description: Analysis defaults for Dart/Flutter site tools.
33
publish_to: none
44

55
environment:
6-
sdk: ^3.3.0
6+
sdk: ^3.4.0
77

88
# NOTE: Code is not allowed in this package.
99
# Do not add dependencies besides the underlying lints package.
1010
dependencies:
11-
dart_flutter_team_lints: ^3.0.0
11+
dart_flutter_team_lints: ^3.1.0

packages/code_excerpt_updater/lib/src/diff/hunk.dart

+13-11
Original file line numberDiff line numberDiff line change
@@ -5,19 +5,21 @@ const eol = '\n';
55
/// A unified-diff hunk consisting of a line-range header followed by the
66
/// unified diff line details. For example:
77
///
8-
/// @@ -1,10 +1,12 @@
9-
/// import 'package:flutter/material.dart';
10-
/// +import 'package:english_words/english_words.dart';
8+
/// ```diff
9+
/// @@ -1,10 +1,12 @@
10+
/// import 'package:flutter/material.dart';
11+
/// +import 'package:english_words/english_words.dart';
1112
///
12-
/// void main() => runApp(MyApp());
13+
/// void main() => runApp(MyApp());
1314
///
14-
/// class MyApp extends StatelessWidget {
15-
/// @override
16-
/// Widget build(BuildContext context) {
17-
/// + final wordPair = WordPair.random();
18-
/// return MaterialApp(
19-
/// title: 'Welcome to Flutter',
20-
/// home: Scaffold(
15+
/// class MyApp extends StatelessWidget {
16+
/// @override
17+
/// Widget build(BuildContext context) {
18+
/// + final wordPair = WordPair.random();
19+
/// return MaterialApp(
20+
/// title: 'Welcome to Flutter',
21+
/// home: Scaffold(
22+
/// ```
2123
class Hunk {
2224
static final Hunk empty = Hunk('');
2325

packages/code_excerpt_updater/pubspec.yaml

+1-1
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ name: code_excerpt_updater
22
publish_to: none
33

44
environment:
5-
sdk: ^3.3.0
5+
sdk: ^3.4.0
66

77
dependencies:
88
args: ^2.4.2

packages/code_excerpter/pubspec.yaml

+2-2
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ name: code_excerpter
22
publish_to: none
33

44
environment:
5-
sdk: ^3.3.0
5+
sdk: ^3.4.0
66

77
dependencies:
88
build: ^2.4.1
@@ -13,5 +13,5 @@ dependencies:
1313
dev_dependencies:
1414
analysis_defaults:
1515
path: ../analysis_defaults
16-
build_runner: ^2.4.8
16+
build_runner: ^2.4.9
1717
test: ^1.25.2

packages/excerpter/pubspec.yaml

+1-1
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ publish_to: none
55
repository: https://github.com/dart-lang/site-shared/tree/main/packages/excerpter
66

77
environment:
8-
sdk: ^3.3.0
8+
sdk: ^3.4.0
99

1010
dependencies:
1111
args: ^2.4.2

packages/inject_dartpad/pubspec.yaml

+3-3
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ name: inject_dartpad
22
publish_to: none
33

44
environment:
5-
sdk: ^3.3.0
5+
sdk: ^3.4.0
66

77
dependencies:
88
html_unescape: ^2.0.0
@@ -11,8 +11,8 @@ dependencies:
1111
dev_dependencies:
1212
analysis_defaults:
1313
path: ../analysis_defaults
14-
build_runner: ^2.4.8
15-
build_web_compilers: ^4.0.9
14+
build_runner: ^2.4.9
15+
build_web_compilers: ^4.0.10
1616
path: ^1.9.0
1717
test: ^1.25.2
1818
webdev: any

0 commit comments

Comments
 (0)