From 85674ebff946bfa79f82b1440ca566181dcb33e2 Mon Sep 17 00:00:00 2001 From: Sigurd Meldgaard Date: Thu, 8 Feb 2024 13:37:41 +0000 Subject: [PATCH] Make a 'runtime' for is:wasm-ready --- lib/src/tag/_specs.dart | 12 +++--------- lib/src/tag/pana_tags.dart | 3 +-- test/goldens/end2end/async-2.11.0.json | 2 +- test/goldens/end2end/http-0.13.0.json | 2 +- test/goldens/end2end/lints-1.0.0.json | 2 +- test/tag/tag_end2end_test.dart | 1 + 6 files changed, 8 insertions(+), 14 deletions(-) diff --git a/lib/src/tag/_specs.dart b/lib/src/tag/_specs.dart index 3e9136dca..88447ba52 100644 --- a/lib/src/tag/_specs.dart +++ b/lib/src/tag/_specs.dart @@ -66,6 +66,7 @@ class Runtime { nativeAot, nativeJit, web, + wasm, ]; static final nativeAot = Runtime( @@ -91,8 +92,8 @@ class Runtime { static final wasm = Runtime( 'wasm', - {..._onAllPlatforms}, - tag: PanaTags.runtimeWasm, + {..._onAllPlatforms, 'ui', 'ui_web', 'js_interop', 'js_interop_unsafe'}, + tag: PanaTags.isWasmReady, ); static final flutterNative = Runtime( @@ -116,12 +117,6 @@ class Runtime { tag: PanaTags.runtimeFlutterWeb, ); - static final flutterWasm = Runtime( - 'flutter-wasm', - {..._onAllPlatforms, 'ui', 'ui_web'}, - tag: PanaTags.runtimeFlutterWasm, - ); - /// For platform detection we allow dart:ui. static final broadWeb = Runtime( 'web', @@ -185,7 +180,6 @@ class Platform { linux, macos, web, - wasm, ]; /// Platforms that binary-only packages will be assigned to. diff --git a/lib/src/tag/pana_tags.dart b/lib/src/tag/pana_tags.dart index 198f97ac6..6c31bf730 100644 --- a/lib/src/tag/pana_tags.dart +++ b/lib/src/tag/pana_tags.dart @@ -17,8 +17,7 @@ abstract class PanaTags { static const runtimeFlutterNative = 'runtime:flutter-native'; static const runtimeFlutterWeb = 'runtime:flutter-web'; static const runtimeWeb = 'runtime:web'; - static const runtimeWasm = 'runtime:wasm'; - static const runtimeFlutterWasm = 'runtime:flutter-wasm'; + static const isWasmReady = 'is:wasm-ready'; // platform tags static const platformAndroid = 'platform:android'; diff --git a/test/goldens/end2end/async-2.11.0.json b/test/goldens/end2end/async-2.11.0.json index 41575fa80..fb388d73b 100644 --- a/test/goldens/end2end/async-2.11.0.json +++ b/test/goldens/end2end/async-2.11.0.json @@ -53,10 +53,10 @@ "platform:linux", "platform:macos", "platform:web", - "platform:wasm", "runtime:native-aot", "runtime:native-jit", "runtime:web", + "is:wasm-ready", "is:null-safe", "is:dart3-compatible", "license:bsd-3-clause", diff --git a/test/goldens/end2end/http-0.13.0.json b/test/goldens/end2end/http-0.13.0.json index 045113a0e..cc85e8061 100644 --- a/test/goldens/end2end/http-0.13.0.json +++ b/test/goldens/end2end/http-0.13.0.json @@ -58,10 +58,10 @@ "platform:linux", "platform:macos", "platform:web", - "platform:wasm", "runtime:native-aot", "runtime:native-jit", "runtime:web", + "is:wasm-ready", "is:null-safe", "is:dart3-compatible", "license:bsd-3-clause", diff --git a/test/goldens/end2end/lints-1.0.0.json b/test/goldens/end2end/lints-1.0.0.json index bb4e75ac9..b72aaef11 100644 --- a/test/goldens/end2end/lints-1.0.0.json +++ b/test/goldens/end2end/lints-1.0.0.json @@ -35,10 +35,10 @@ "platform:linux", "platform:macos", "platform:web", - "platform:wasm", "runtime:native-aot", "runtime:native-jit", "runtime:web", + "is:wasm-ready", "is:null-safe", "is:dart3-compatible", "license:bsd-3-clause", diff --git a/test/tag/tag_end2end_test.dart b/test/tag/tag_end2end_test.dart index 16e1a3de2..950391c43 100644 --- a/test/tag/tag_end2end_test.dart +++ b/test/tag/tag_end2end_test.dart @@ -48,6 +48,7 @@ void main() { 'runtime:native-jit', 'runtime:native-aot', 'runtime:web', + 'is:wasm-ready', }, explanations: isEmpty); _expectTagging(tagger.flutterPluginTags, tags: isEmpty);