From 711de432add8bdce80628a7b6ba248a22e717068 Mon Sep 17 00:00:00 2001 From: Istvan Soos Date: Mon, 3 Mar 2025 13:49:52 +0100 Subject: [PATCH] Fix golden files caused by new dartdoc update. --- test/goldens/end2end/async-2.11.0.json | 2 +- test/goldens/end2end/async-2.11.0.json_report.md | 4 +++- test/goldens/end2end/dnd-2.0.1.json | 2 +- test/goldens/end2end/dnd-2.0.1.json_report.md | 4 ++-- 4 files changed, 7 insertions(+), 5 deletions(-) diff --git a/test/goldens/end2end/async-2.11.0.json b/test/goldens/end2end/async-2.11.0.json index f7e9ee3f7..d50d68a33 100644 --- a/test/goldens/end2end/async-2.11.0.json +++ b/test/goldens/end2end/async-2.11.0.json @@ -79,7 +79,7 @@ "grantedPoints": 10, "maxPoints": 20, "status": "failed", - "summary": "### [*] 10/10 points: 20% or more of the public API has dartdoc comments\n\n246 out of 246 API elements (100.0 %) have documentation comments.\n\n### [x] 0/10 points: Package has an example\n\n
\n\nNo example found.\n\n\nSee [package layout](https://dart.dev/tools/pub/package-layout#examples) guidelines on how to add an example.\n
\n" + "summary": "### [*] 10/10 points: 20% or more of the public API has dartdoc comments\n\n246 out of 263 API elements (93.5 %) have documentation comments.\n\nSome symbols that are missing documentation: `async.AsyncMemoizer.AsyncMemoizer.new`, `async.ChunkedStreamReader.ChunkedStreamReader.new`, `async.DelegatingFuture.DelegatingFuture.new`, `async.DelegatingStream.DelegatingStream.new`, `async.ErrorResult.ErrorResult.new`.\n\n### [x] 0/10 points: Package has an example\n\n
\n\nNo example found.\n\n\nSee [package layout](https://dart.dev/tools/pub/package-layout#examples) guidelines on how to add an example.\n
\n" }, { "id": "platform", diff --git a/test/goldens/end2end/async-2.11.0.json_report.md b/test/goldens/end2end/async-2.11.0.json_report.md index 8f40a18d5..69478b6e1 100644 --- a/test/goldens/end2end/async-2.11.0.json_report.md +++ b/test/goldens/end2end/async-2.11.0.json_report.md @@ -15,7 +15,9 @@ Detected license: `BSD-3-Clause`. ### [*] 10/10 points: 20% or more of the public API has dartdoc comments -246 out of 246 API elements (100.0 %) have documentation comments. +246 out of 263 API elements (93.5 %) have documentation comments. + +Some symbols that are missing documentation: `async.AsyncMemoizer.AsyncMemoizer.new`, `async.ChunkedStreamReader.ChunkedStreamReader.new`, `async.DelegatingFuture.DelegatingFuture.new`, `async.DelegatingStream.DelegatingStream.new`, `async.ErrorResult.ErrorResult.new`. ### [x] 0/10 points: Package has an example diff --git a/test/goldens/end2end/dnd-2.0.1.json b/test/goldens/end2end/dnd-2.0.1.json index 97174a19e..a3da97c5c 100644 --- a/test/goldens/end2end/dnd-2.0.1.json +++ b/test/goldens/end2end/dnd-2.0.1.json @@ -63,7 +63,7 @@ "grantedPoints": 20, "maxPoints": 20, "status": "passed", - "summary": "### [*] 10/10 points: 20% or more of the public API has dartdoc comments\n\n70 out of 72 API elements (97.2 %) have documentation comments.\n\nSome symbols that are missing documentation: `dnd`, `dnd.DraggablesAcceptor.draggableIds`.\n\n### [*] 10/10 points: Package has an example\n" + "summary": "### [*] 10/10 points: 20% or more of the public API has dartdoc comments\n\n70 out of 77 API elements (90.9 %) have documentation comments.\n\nSome symbols that are missing documentation: `dnd`, `dnd.Acceptor.Acceptor.new`, `dnd.AnimationHelper.AnimationHelper.new`, `dnd.CloneAvatarHandler.CloneAvatarHandler.new`, `dnd.DraggablesAcceptor.DraggablesAcceptor.new`.\n\n### [*] 10/10 points: Package has an example\n" }, { "id": "platform", diff --git a/test/goldens/end2end/dnd-2.0.1.json_report.md b/test/goldens/end2end/dnd-2.0.1.json_report.md index ef7ef5745..e485c3b0d 100644 --- a/test/goldens/end2end/dnd-2.0.1.json_report.md +++ b/test/goldens/end2end/dnd-2.0.1.json_report.md @@ -15,9 +15,9 @@ Detected license: `MIT`. ### [*] 10/10 points: 20% or more of the public API has dartdoc comments -70 out of 72 API elements (97.2 %) have documentation comments. +70 out of 77 API elements (90.9 %) have documentation comments. -Some symbols that are missing documentation: `dnd`, `dnd.DraggablesAcceptor.draggableIds`. +Some symbols that are missing documentation: `dnd`, `dnd.Acceptor.Acceptor.new`, `dnd.AnimationHelper.AnimationHelper.new`, `dnd.CloneAvatarHandler.CloneAvatarHandler.new`, `dnd.DraggablesAcceptor.DraggablesAcceptor.new`. ### [*] 10/10 points: Package has an example