Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DartPad inject script sometimes fails #2893

Closed
johnpryan opened this issue Mar 7, 2024 · 1 comment · Fixed by #2917
Closed

DartPad inject script sometimes fails #2893

johnpryan opened this issue Mar 7, 2024 · 1 comment · Fixed by #2917
Assignees
Labels
area-embedding inject-script P1 A high priority bug; for example, a single project is unusable or has many test failures

Comments

@johnpryan
Copy link
Contributor

When I was testing dart-lang/site-www#5627 (comment) I noticed that some of the DartPad embeds are displaying the default snippet. We might need to listen for these events right away, instead of when the Editor widget is created (#2858)

@parlough parlough self-assigned this Mar 23, 2024
@parlough parlough added P1 A high priority bug; for example, a single project is unusable or has many test failures inject-script area-embedding labels Mar 23, 2024
@parlough
Copy link
Member

parlough commented Mar 26, 2024

Taking a look at this, I think it's perhaps not listening to the event too late, but rather not distinguishing between the embeds on the page for which sent the "ready" message. I'll investigate adding a way to distinguish between them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-embedding inject-script P1 A high priority bug; for example, a single project is unusable or has many test failures
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants