From 07959c84e8e646b93fd8ced70ac4b5174fab7265 Mon Sep 17 00:00:00 2001 From: Will Childs-Klein Date: Fri, 7 Mar 2025 18:21:01 -0500 Subject: [PATCH] PR feedback --- src/com/amazon/corretto/crypto/provider/EdGen.java | 2 +- .../crypto/provider/test/RemoveDefaultProvidersTest.java | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/com/amazon/corretto/crypto/provider/EdGen.java b/src/com/amazon/corretto/crypto/provider/EdGen.java index 1fa3a209..6a911880 100644 --- a/src/com/amazon/corretto/crypto/provider/EdGen.java +++ b/src/com/amazon/corretto/crypto/provider/EdGen.java @@ -42,7 +42,7 @@ public void initialize(final int keysize, final SecureRandom random) { public KeyPair generateKeyPair() { final EvpEdPrivateKey privateKey = new EvpEdPrivateKey(generateEvpEdKey()); final EvpEdPublicKey publicKey = privateKey.getPublicKey(); - if (kf == null) { // This case indicates JDK EdDSA support conditions as described in the ctor + if (kf == null) { // This case indicates JDK EdDSA conditions as described in the constructor return new KeyPair(publicKey, privateKey); } try { diff --git a/tst/com/amazon/corretto/crypto/provider/test/RemoveDefaultProvidersTest.java b/tst/com/amazon/corretto/crypto/provider/test/RemoveDefaultProvidersTest.java index a4f6a108..706e1b79 100644 --- a/tst/com/amazon/corretto/crypto/provider/test/RemoveDefaultProvidersTest.java +++ b/tst/com/amazon/corretto/crypto/provider/test/RemoveDefaultProvidersTest.java @@ -50,7 +50,7 @@ static void restoreProviders() { @Test void testEdDSASignature() throws Exception { - final byte[] message = new byte[0]; + final byte[] message = new byte[] {0x01, 0x02, 0x03, 0x04, 0x05, 0x06, 0x07, 0x08}; final KeyPair keyPair = KeyPairGenerator.getInstance("EdDSA", NATIVE_PROVIDER).generateKeyPair(); final Signature signature = Signature.getInstance("EdDSA", NATIVE_PROVIDER);