Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

provisioning azure: add remote ign ex on private azure blob #699

Merged
merged 1 commit into from
Jan 31, 2025
Merged

provisioning azure: add remote ign ex on private azure blob #699

merged 1 commit into from
Jan 31, 2025

Conversation

prestist
Copy link
Contributor

depends on changes found here => coreos/ignition#1923

@prestist prestist mentioned this pull request Jan 25, 2025
Merged
yasminvalim
yasminvalim approved these changes Jan 27, 2025
View reviewed changes
Copy link
Contributor

@yasminvalim yasminvalim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

@prestist prestist marked this pull request as ready for review January 31, 2025 14:49
@prestist prestist merged commit 4b58c02 into coreos:main Jan 31, 2025
1 check passed
@travier
Copy link
Member

travier commented Feb 3, 2025

coreos/ignition#1923 got merged, but it did not land in an Ignition release nor in an FCOS one or did I miss something?

Ideally we should have waited until that functionality reached at least next/testing before merging this PR.

@travier travier mentioned this pull request Feb 3, 2025
Open
travier
travier reviewed Feb 3, 2025
View reviewed changes
Copy link
Member

@travier travier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some nits for a followup PR

modules/ROOT/pages/provisioning-azure.adoc
@@ -83,3 +83,42 @@ az vm create -n "${az_vm_name}" -g "${az_resource_group}" --image "${az_image_na
----
ssh core@<ip address>
----

== Launching a VM instance using custom-data and a private azure blob
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

azure -> Azure

modules/ROOT/pages/provisioning-azure.adoc
az_blob_ignition_file_name=privateConfig.ign
----

. Upload your ign file to azure blob storage.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

azure -> Azure

@travier
Copy link
Member

travier commented Feb 3, 2025

As this is not tied to an Ignition specification, we should probably add a note about the FCOS versions that support that once it lands in FCOS.

@travier travier mentioned this pull request Feb 5, 2025
Merged
@prestist
Copy link
Contributor Author

prestist commented Feb 5, 2025

coreos/ignition#1923 got merged, but it did not land in an Ignition release nor in an FCOS one or did I miss something?

Ideally we should have waited until that functionality reached at least next/testing before merging this PR.

I am so sorry, I misunderstood the order at which this documentation had to land. Should we revert it? we are about to do an ignition release, but I have been trying to wait for the IONOS pr.

Again, I am so sorry for merging out of order, I dont know what I was thinking.

@travier
Copy link
Member

travier commented Feb 5, 2025

Revert here: #701

@prestist
Copy link
Contributor Author

prestist commented Feb 5, 2025

Followup #702

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@travier travier travier approved these changes

@dustymabe dustymabe dustymabe approved these changes

@yasminvalim yasminvalim yasminvalim approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@prestist @travier @dustymabe @yasminvalim