Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Docker CE installation instructions page #641

Merged
merged 3 commits into from
May 15, 2024
Merged

Add Docker CE installation instructions page #641

merged 3 commits into from
May 15, 2024

Conversation

hrismarin
Copy link
Contributor

See: #639

travier
travier reviewed May 13, 2024
View reviewed changes
Copy link
Member

@travier travier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this. Added some minor comments.

Docker CE: Improve sentence, commands, and sections order
ca928f1 
The entire page is with each sentence on a separate line.
Combine the two `rpm-ostree` commands into one.
Correct sequence of sections.
travier
travier approved these changes May 14, 2024
View reviewed changes
Copy link
Member

@travier travier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks

dustymabe
dustymabe reviewed May 14, 2024
View reviewed changes
Copy link
Member

@dustymabe dustymabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks pretty good. Maybe we move it in the nav to under the OS Extensions entry since they are similar?

dustymabe
dustymabe approved these changes May 15, 2024
View reviewed changes
Copy link
Member

@dustymabe dustymabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dustymabe dustymabe merged commit 9da0df3 into coreos:main May 15, 2024
1 check passed
This was referenced May 15, 2024
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dustymabe dustymabe dustymabe approved these changes

@travier travier travier approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hrismarin @dustymabe @travier