cargo: add feature flag which disables nmstate by default #1609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the latest release for f42 dependencies which are required for nmstate will no longer be available. There is a PR which has landed nmstate/nmstate#2820 but a build of nmstate needs to land with those changes in f42. To prevent issues for coreos-installer add a featureflag to make nmstate dependency an optional one. If the feature 'use-nmstate' is not available coreos-installer will lose functionality around customizing network settings. By adding the feature 'use-nmstate' functionality would be restored. resolves: coreos#1602
prestist
force-pushed
the
add-feature-flag-nmstate
branch
from
90c1a9a to
4fb379f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the latest release for f42 dependencies which are required for nmstate will no longer be available.
There is a PR which has landed nmstate/nmstate#2820 but a build of nmstate needs to land with those changes in f42.
To prevent issues for coreos-installer add a featureflag to make nmstate dependency an optional one. If the feature 'use-nmstate' is not available coreos-installer will lose functionality around customizing network settings. By adding the feature 'use-nmstate' functionality would be restored.