Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installation of tagfiles for lite #267

Open
anutosh491 opened this issue Mar 4, 2025 · 0 comments
Open

Installation of tagfiles for lite #267

anutosh491 opened this issue Mar 4, 2025 · 0 comments
Labels
bug Something isn't working

Comments

@anutosh491
Copy link
Collaborator

Currently while building xeus-cpp-lite I see

-- Install configuration: "Release"
-- Up-to-date: /Users/anutosh491/micromamba/envs/xeus-cpp-wasm-host/share/xeus-cpp/tagfiles
-- Up-to-date: /Users/anutosh491/micromamba/envs/xeus-cpp-wasm-host/share/xeus-cpp/tagfiles/cppreference-doxygen-web.tag
-- Up-to-date: /Users/anutosh491/micromamba/envs/xeus-cpp-wasm-host/etc/xeus-cpp/tags.d
-- Up-to-date: /Users/anutosh491/micromamba/envs/xeus-cpp-wasm-host/etc/xeus-cpp/tags.d/stl.json
-- Up-to-date: /Users/anutosh491/micromamba/envs/xeus-cpp-wasm-host/share/jupyter/kernels
-- Up-to-date: /Users/anutosh491/micromamba/envs/xeus-cpp-wasm-host/share/jupyter/kernels/xcpp20
-- Installing: /Users/anutosh491/micromamba/envs/xeus-cpp-wasm-host/share/jupyter/kernels/xcpp20/kernel.json
-- Installing: /Users/anutosh491/micromamba/envs/xeus-cpp-wasm-host/share/jupyter/kernels/xcpp20/logo-64x64.png
-- Installing: /Users/anutosh491/micromamba/envs/xeus-cpp-wasm-host/share/jupyter/kernels/xcpp20/logo-32x32.png
-- Installing: /Users/anutosh491/micromamba/envs/xeus-cpp-wasm-host/share/jupyter/kernels/xcpp20/logo-svg.svg
-- Installing: /Users/anutosh491/micromamba/envs/xeus-cpp-wasm-host/lib/cmake/xeus-cpp/xeus-cppConfig.cmake
-- Installing: /Users/anutosh491/micromamba/envs/xeus-cpp-wasm-host/lib/cmake/xeus-cpp/xeus-cppConfigVersion.cmake
-- Installing: /Users/anutosh491/micromamba/envs/xeus-cpp-wasm-host/bin/xcpp.js
-- Installing: /Users/anutosh491/micromamba/envs/xeus-cpp-wasm-host/bin/xcpp.wasm
-- Installing: /Users/anutosh491/micromamba/envs/xeus-cpp-wasm-host/bin/xcpp.data

If you see, the .tag and the .d files also end up in the prefix just like the native case.

But the point is that jupyterlite-xeus only takes care of the kernels dir, the xx.cmake files and the xx.js, xx.wasm, xx.data files. It won't be handling the tagfiles.

Rather for the inspect request to work, these files are taken care of here.

xeus-cpp/CMakeLists.txt

Lines 449 to 450 in b6a7267

PUBLIC "SHELL: --preload-file ${XEUS_CPP_DATA_DIR}@/share/xeus-cpp"
PUBLIC "SHELL: --preload-file ${XEUS_CPP_CONF_DIR}@/etc/xeus-cpp"

Hence technically these files being installed are redundant for the lite case. No need to install them while building xeus-cpp-lite.

@github-actions github-actions bot added the Needs triage Used in auto labelling of new issues label Mar 4, 2025
@anutosh491 anutosh491 added bug Something isn't working and removed Needs triage Used in auto labelling of new issues labels Mar 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant