Skip to content

Commit f441125

Browse files
Repeat frontend version warning at the end.
This way someone running ComfyUI with the command line is more likely to actually see it.
1 parent d2a0fb6 commit f441125

File tree

3 files changed

+18
-1
lines changed

3 files changed

+18
-1
lines changed

app/frontend_management.py

+2-1
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@
1717
from typing_extensions import NotRequired
1818

1919
from comfy.cli_args import DEFAULT_VERSION_STRING
20+
import app.logger
2021

2122
# The path to the requirements.txt file
2223
req_path = Path(__file__).parents[1] / "requirements.txt"
@@ -42,7 +43,7 @@ def parse_version(version: str) -> tuple[int, int, int]:
4243
with open(req_path, "r", encoding="utf-8") as f:
4344
required_frontend = parse_version(f.readline().split("=")[-1])
4445
if frontend_version < required_frontend:
45-
logging.warning("________________________________________________________________________\nWARNING WARNING WARNING WARNING WARNING\n\nInstalled frontend version {} is lower than the recommended version {}.\n\n{}\n________________________________________________________________________".format('.'.join(map(str, frontend_version)), '.'.join(map(str, required_frontend)), frontend_install_warning_message()))
46+
app.logger.log_startup_warning("________________________________________________________________________\nWARNING WARNING WARNING WARNING WARNING\n\nInstalled frontend version {} is lower than the recommended version {}.\n\n{}\n________________________________________________________________________".format('.'.join(map(str, frontend_version)), '.'.join(map(str, required_frontend)), frontend_install_warning_message()))
4647
else:
4748
logging.info("ComfyUI frontend version: {}".format(frontend_version_str))
4849
except Exception as e:

app/logger.py

+14
Original file line numberDiff line numberDiff line change
@@ -82,3 +82,17 @@ def setup_logger(log_level: str = 'INFO', capacity: int = 300, use_stdout: bool
8282
logger.addHandler(stdout_handler)
8383

8484
logger.addHandler(stream_handler)
85+
86+
87+
STARTUP_WARNINGS = []
88+
89+
90+
def log_startup_warning(msg):
91+
logging.warning(msg)
92+
STARTUP_WARNINGS.append(msg)
93+
94+
95+
def print_startup_warnings():
96+
for s in STARTUP_WARNINGS:
97+
logging.warning(s)
98+
STARTUP_WARNINGS.clear()

main.py

+2
Original file line numberDiff line numberDiff line change
@@ -139,6 +139,7 @@ def execute_script(script_path):
139139
import nodes
140140
import comfy.model_management
141141
import comfyui_version
142+
import app.logger
142143

143144

144145
def cuda_malloc_warning():
@@ -299,6 +300,7 @@ async def start_all():
299300
event_loop, _, start_all_func = start_comfyui()
300301
try:
301302
x = start_all_func()
303+
app.logger.print_startup_warnings()
302304
event_loop.run_until_complete(x)
303305
except KeyboardInterrupt:
304306
logging.info("\nStopped server")

0 commit comments

Comments
 (0)