From 65443273bba1a7d63a632f053fb1c655f58117ed Mon Sep 17 00:00:00 2001 From: Paul Cramer Date: Tue, 11 Mar 2025 09:57:01 -0700 Subject: [PATCH] Update type --- src/identity/hooks/useNames.test.tsx | 4 ++-- src/identity/hooks/useNames.ts | 3 ++- src/identity/types.ts | 2 +- src/identity/utils/getNames.test.ts | 10 +++++----- src/identity/utils/getNames.ts | 3 ++- 5 files changed, 12 insertions(+), 10 deletions(-) diff --git a/src/identity/hooks/useNames.test.tsx b/src/identity/hooks/useNames.test.tsx index 67d6174973..5611a8ba9f 100644 --- a/src/identity/hooks/useNames.test.tsx +++ b/src/identity/hooks/useNames.test.tsx @@ -62,7 +62,7 @@ describe('useNames', () => { () => useNames({ addresses: testAddresses, - chain: base as unknown as typeof mainnet, + chain: base, }), { wrapper: getNewReactQueryTestProvider(), @@ -89,7 +89,7 @@ describe('useNames', () => { () => useNames({ addresses: testAddresses, - chain: optimism as unknown as typeof mainnet, + chain: optimism, }), { wrapper: getNewReactQueryTestProvider(), diff --git a/src/identity/hooks/useNames.ts b/src/identity/hooks/useNames.ts index 82cf56b76c..80071bc92f 100644 --- a/src/identity/hooks/useNames.ts +++ b/src/identity/hooks/useNames.ts @@ -3,11 +3,12 @@ import { DEFAULT_QUERY_OPTIONS } from '@/internal/constants'; import { useQuery } from '@tanstack/react-query'; import type { Address } from 'viem'; import { mainnet } from 'viem/chains'; +import type { Chain } from 'wagmi/chains'; import type { GetNameReturnType, UseQueryOptions } from '../types'; export type UseNamesOptions = { addresses: Address[]; - chain?: typeof mainnet; + chain?: Chain; }; /** diff --git a/src/identity/types.ts b/src/identity/types.ts index 5835b262df..3f03b255b6 100644 --- a/src/identity/types.ts +++ b/src/identity/types.ts @@ -300,7 +300,7 @@ export type UseNamesOptions = { /** Array of addresses to resolve ENS or Basenames for */ addresses: Address[]; /** Optional chain for domain resolution */ - chain?: typeof mainnet; + chain?: Chain; }; /** diff --git a/src/identity/utils/getNames.test.ts b/src/identity/utils/getNames.test.ts index 06d0ae0078..e9ee66f50a 100644 --- a/src/identity/utils/getNames.test.ts +++ b/src/identity/utils/getNames.test.ts @@ -1,6 +1,6 @@ import { publicClient } from '@/core/network/client'; import type { Address } from 'viem'; -import { base, type mainnet, optimism } from 'viem/chains'; +import { base, optimism } from 'viem/chains'; import { beforeEach, describe, expect, it, vi } from 'vitest'; import type { Mock } from 'vitest'; import L2ResolverAbi from '../abis/L2ResolverAbi'; @@ -71,7 +71,7 @@ describe('getNames', () => { const names = await getNames({ addresses: walletAddresses, - chain: base as unknown as typeof mainnet, + chain: base, }); expect(names).toEqual(expectedBaseNames); @@ -105,7 +105,7 @@ describe('getNames', () => { const names = await getNames({ addresses: walletAddresses, - chain: base as unknown as typeof mainnet, + chain: base, }); expect(names).toEqual(['user1.base', 'user2.base', 'user3.eth']); @@ -129,7 +129,7 @@ describe('getNames', () => { const names = await getNames({ addresses: walletAddresses, - chain: base as unknown as typeof mainnet, + chain: base, }); expect(names).toEqual(expectedEnsNames); @@ -141,7 +141,7 @@ describe('getNames', () => { await expect( getNames({ addresses: walletAddresses, - chain: optimism as unknown as typeof mainnet, + chain: optimism, }), ).rejects.toBe( 'ChainId not supported, name resolution is only supported on Ethereum and Base.', diff --git a/src/identity/utils/getNames.ts b/src/identity/utils/getNames.ts index 684c6d5b21..965744abde 100644 --- a/src/identity/utils/getNames.ts +++ b/src/identity/utils/getNames.ts @@ -1,6 +1,7 @@ import type { Basename, GetNameReturnType } from '@/identity/types'; import type { Address } from 'viem'; import { mainnet } from 'viem/chains'; +import type { Chain } from 'wagmi/chains'; import { getChainPublicClient } from '../../core/network/getChainPublicClient'; import { isBase } from '../../core/utils/isBase'; import { isEthereum } from '../../core/utils/isEthereum'; @@ -10,7 +11,7 @@ import { convertReverseNodeToBytes } from './convertReverseNodeToBytes'; export type GetNames = { addresses: Address[]; - chain?: typeof mainnet; + chain?: Chain; }; /**