Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some tags are missing #131

Open
ChandlerLiu3 opened this issue Mar 6, 2025 · 2 comments
Open

Some tags are missing #131

ChandlerLiu3 opened this issue Mar 6, 2025 · 2 comments

Comments

@ChandlerLiu3
Copy link

ChandlerLiu3 commented Mar 6, 2025

Recently, I tried to read some arxml files with this lib and found some tags are missing:

  • TRIGGER-INTERFACE, this is the 6th interface type
  • SERVICE-SW-COMPONENT-TYPE
  • ECU-ABSTRACTION-SW-COMPONENT-TYPE: this one can be read from arxml file as an application SWC
            'ECU-ABSTRACTION-SW-COMPONENT-TYPE': self._read_application_sw_component_type,

Roughly converted an arxml (SWC, port and interfaces) to a dot file, and render it with graphviz, to visualize the model.

@ChandlerLiu3
Copy link
Author

Hi, @cogu : can I join and contribute?

@cogu
Copy link
Owner

cogu commented Mar 12, 2025

Hi @ChandlerLiu3, you don't seem to have any public Python repositories of your own and I'm therefore unable to assess your Python skill level. Open source developers these days don't seem to bother to even write unit tests.

I'm aware that some XML tags are not implemented. The various ComponentTypes are pretty similar to each other as you have observed.

I just added support for adding both external and internal trigger-points in my last commit (on a branch) but the port interface itself is still not implemented. Will add it soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants