Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate how we handle SGs #1094

Open
gregharvey opened this issue Jun 15, 2023 · 0 comments
Open

Consolidate how we handle SGs #1094

gregharvey opened this issue Jun 15, 2023 · 0 comments
Assignees
Labels
2.x enhancement New feature or request

Comments

@gregharvey
Copy link
Member

We should check through all ce-provision AWS roles that require lists of security groups and:

  • where they currently pass names to a module, check if the module supports IDs and switch over
  • centralise looking up SG IDs from a list of names, as we do here, in the EFS role

That way we have consistency because:

  • we are always passing SG IDs, not names, to Ansible; and
  • we allow users to pass a list of SG names anyway
@gregharvey gregharvey added the enhancement New feature or request label Jun 15, 2023
@gregharvey gregharvey added the 2.x label Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.x enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants