DELETE doesn't propagate the body

[slinkydeveloper]

The HTTP DELETE method supports a body, as defined in https://www.rfc-editor.org/rfc/rfc7231#section-4.3.5:

A payload within a DELETE request message has no defined semantics;
sending a payload body on a DELETE request might cause some existing
implementations to reject the request.

But the code generator simply ignores it. It should be easy to fix by changing this line of code: https://github.com/cjbooms/fabrikt/blob/master/src/main/kotlin/com/cjbooms/fabrikt/generators/client/OkHttpSimpleClientGenerator.kt#L212

[slinkydeveloper]

A proposed PR here: #226

[aderington]

I've also run into this issue. I was curious if there was an plan to merge the posted PR (or similar). Thank you!

[cjbooms]

Open to merging a fix. From what i recall, it wasn't clear what that PR was doing, and requests for clarification or tests were ignored.

[aderington]

I agree that the current PR could use some tweaks. I added a couple of comments to the PR with what I think is going on and a suggestion for improving the PR. I have not cloned the repo though, and I'm definitely not an expert in code generation, so take it with a grain of salt.

tl;dr;

"DELETE" -> {
  val hasBodyParameters = parameters.any { it is BodyParameter }
  if (hasBodyParameters) {
      this.addRequestSerializerStatement("delete")
  } else {
       this.add("\n.delete()")
  }
}