Skip to content

Commit 5271053

Browse files
committed
Add documentation for ActionCallback
1 parent 3b541ab commit 5271053

File tree

2 files changed

+27
-11
lines changed

2 files changed

+27
-11
lines changed

app/src/main/res/layout/activity_main.xml

+11-11
Original file line numberDiff line numberDiff line change
@@ -8,16 +8,16 @@
88

99
<Button
1010
android:id="@+id/buttonDefaultDialog"
11-
android:layout_width="wrap_content"
11+
android:layout_width="161dp"
1212
android:layout_height="60dp"
1313
android:layout_marginBottom="8dp"
1414
android:layout_marginEnd="8dp"
1515
android:layout_marginStart="8dp"
1616
android:layout_marginTop="8dp"
17-
android:text="Show Rating Dialog"
17+
android:text="Show Default"
1818
app:layout_constraintBottom_toBottomOf="parent"
1919
app:layout_constraintEnd_toEndOf="parent"
20-
app:layout_constraintHorizontal_bias="0.086"
20+
app:layout_constraintHorizontal_bias="0.04"
2121
app:layout_constraintStart_toStartOf="parent"
2222
app:layout_constraintTop_toTopOf="parent"
2323
app:layout_constraintVertical_bias="0.0" />
@@ -28,10 +28,10 @@
2828
android:layout_height="wrap_content"
2929
android:layout_marginEnd="8dp"
3030
android:layout_marginStart="8dp"
31-
android:layout_marginTop="28dp"
31+
android:layout_marginTop="12dp"
3232
android:text="Force Rate Now"
3333
app:layout_constraintEnd_toEndOf="parent"
34-
app:layout_constraintHorizontal_bias="0.541"
34+
app:layout_constraintHorizontal_bias="0.502"
3535
app:layout_constraintStart_toStartOf="parent"
3636
app:layout_constraintTop_toBottomOf="@+id/buttonNoRemindLater" />
3737

@@ -42,7 +42,7 @@
4242
android:layout_marginEnd="8dp"
4343
android:layout_marginStart="8dp"
4444
android:layout_marginTop="8dp"
45-
android:text="Show Dialog No Remind Never"
45+
android:text="Show No Remind Never"
4646
app:layout_constraintEnd_toEndOf="parent"
4747
app:layout_constraintHorizontal_bias="1.0"
4848
app:layout_constraintStart_toStartOf="parent"
@@ -54,10 +54,10 @@
5454
android:layout_height="wrap_content"
5555
android:layout_marginEnd="8dp"
5656
android:layout_marginStart="8dp"
57-
android:layout_marginTop="76dp"
58-
android:text="Show Dialog No Remind Later"
57+
android:layout_marginTop="80dp"
58+
android:text="Show No Remind Later"
5959
app:layout_constraintEnd_toEndOf="parent"
60-
app:layout_constraintHorizontal_bias="0.582"
60+
app:layout_constraintHorizontal_bias="0.503"
6161
app:layout_constraintStart_toStartOf="parent"
6262
app:layout_constraintTop_toTopOf="parent" />
6363

@@ -67,10 +67,10 @@
6767
android:layout_height="wrap_content"
6868
android:layout_marginEnd="8dp"
6969
android:layout_marginStart="8dp"
70-
android:layout_marginTop="28dp"
70+
android:layout_marginTop="12dp"
7171
android:text="Reset Data"
7272
app:layout_constraintEnd_toEndOf="parent"
73-
app:layout_constraintHorizontal_bias="0.536"
73+
app:layout_constraintHorizontal_bias="0.501"
7474
app:layout_constraintStart_toStartOf="parent"
7575
app:layout_constraintTop_toBottomOf="@+id/buttonRateNow" />
7676
</android.support.constraint.ConstraintLayout>

ratingdialok/src/main/java/org/chrjs/ratingdialok/RatingDialok.kt

+16
Original file line numberDiff line numberDiff line change
@@ -33,9 +33,24 @@ class RatingDialok(ctx: Context) {
3333
* Action Callback for the Dialog Actions
3434
*/
3535
interface ActionCallback {
36+
/**
37+
* Is called when user taps on the remind later button or the dialog is canceled
38+
*/
3639
fun remindLaterClicked()
40+
41+
/**
42+
* Is called when user taps on the rate button
43+
*/
3744
fun rateNowClicked()
45+
46+
/**
47+
* Is called when user taps on remind never
48+
*/
3849
fun remindNeverAgainClicked()
50+
51+
/**
52+
* Is called when the dialog is shown
53+
*/
3954
fun dialogShown()
4055
}
4156

@@ -194,6 +209,7 @@ class RatingDialok(ctx: Context) {
194209
* - Launch Count
195210
* - First Launch Date
196211
*/
212+
@Suppress("RedundantVisibilityModifier")
197213
public fun reset() {
198214
setLaunchCount(0)
199215
val editor = sharedPreferences.edit()

0 commit comments

Comments
 (0)