Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unsupported Devices Should not be referenced in groups #73

Open
ejpenney opened this issue Jan 30, 2025 · 1 comment
Open

Unsupported Devices Should not be referenced in groups #73

ejpenney opened this issue Jan 30, 2025 · 1 comment
Labels
bug Something isn't working

Comments

@ejpenney
Copy link

As discussed in Discord, the official Hue App gets very confused if a group in state.yaml mentions a child that has no other references.

Snippet from convo:

 2025-01-30T19:27:42.802Z INFO  bifrost::z2m                              > [server1] Adding light IeeeAddress(0017880108e24db8): [Back Deck Bulb] (LTA003)
 2025-01-30T19:27:42.802Z DEBUG bifrost::z2m                              > [server1] Ignoring unsupported device Back Deck String
 2025-01-30T19:27:42.805Z DEBUG bifrost::z2m                              > [server1] room/f4a64f2a-70e8-56d0-bbcc-ed8c8db2e9a2 (Back Deck) is new, adding..

Here's the entry for the group from state.yaml:

  f4a64f2a-70e8-56d0-bbcc-ed8c8db2e9a2:
    type: room
    children:
    - rid: e0004380-6f53-5b38-8ef8-5a65931317bf
      rtype: device
    - rid: '1c792ce2-727c-565c-b0ff-411412108797'
      rtype: device
    metadata:
      name: Back Deck
      archetype: home
    services:
    - rid: '62400369-a1de-58f1-aed3-06c75b599617'
      rtype: grouped_light

The string "e0004380-6f53-5b38-8ef8-5a65931317bf" occurs 5 times in state.yaml (and indeed seems to be Back Deck Bulb) but "1c792ce2-727c-565c-b0ff-411412108797" only occurs this once during the group entry, and I suspect it's the "ignored" device.

@chrivers
Copy link
Owner

chrivers commented Feb 4, 2025

Thank you for the detailed report :)

I'll mark this as a bug. I'm working on refactoring the entire internal data model at the moment, so I think during or after that work, is a good time to look at this 👍

@chrivers chrivers added the bug Something isn't working label Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants