You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The sound-controller works, but I'd prefer to shy-away from using Dependency macro's to access flamework controllers in React component. React shouldn't need to know about Flamework at all to work, but the current approach doesn't easily allow this. Requiring flamework singleton's in React is a very quick and sure fire way to break storybooks.
That being said, audio also doesn't necessarily need to play during storybooks (although it'd be nice), so just early returning while IS_EDIT is true is not the most unreasonable approach, but I still believe it would be a better approach to avoid Flamework altogether.
The text was updated successfully, but these errors were encountered:
The sound-controller works, but I'd prefer to shy-away from using Dependency macro's to access flamework controllers in React component. React shouldn't need to know about Flamework at all to work, but the current approach doesn't easily allow this. Requiring flamework singleton's in React is a very quick and sure fire way to break storybooks.
That being said, audio also doesn't necessarily need to play during storybooks (although it'd be nice), so just early returning while IS_EDIT is true is not the most unreasonable approach, but I still believe it would be a better approach to avoid Flamework altogether.
The text was updated successfully, but these errors were encountered: