Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better audio solutions #36

Open
christopher-buss opened this issue Jun 13, 2024 · 0 comments
Open

Better audio solutions #36

christopher-buss opened this issue Jun 13, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@christopher-buss
Copy link
Owner

The sound-controller works, but I'd prefer to shy-away from using Dependency macro's to access flamework controllers in React component. React shouldn't need to know about Flamework at all to work, but the current approach doesn't easily allow this. Requiring flamework singleton's in React is a very quick and sure fire way to break storybooks.

That being said, audio also doesn't necessarily need to play during storybooks (although it'd be nice), so just early returning while IS_EDIT is true is not the most unreasonable approach, but I still believe it would be a better approach to avoid Flamework altogether.

@christopher-buss christopher-buss added the enhancement New feature or request label Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant