refactor: move logging to use userId over player name

Author: christopher-buss

src/client/network.ts

@@ -13,10 +13,10 @@ export const Functions = GlobalFunctions.createClient({
 // Log warnings for bad requests and responses in development
 if ($NODE_ENV === "development") {
 	GlobalEvents.registerHandler("onBadRequest", (player, message) => {
-		Log.Warn(`Bad request from ${player.Name}: ${message}`);
+		Log.Warn(`Bad request from ${player.UserId}: ${message}`);
 	});
 
 	GlobalFunctions.registerHandler("onBadResponse", (player, message) => {
-		Log.Warn(`Bad response from ${player.Name}: ${message}`);
+		Log.Warn(`Bad response from ${player.UserId}: ${message}`);
 	});
 }

src/server/network.ts

@@ -12,10 +12,10 @@ export const Functions = GlobalFunctions.createServer({
 
 if ($NODE_ENV === "development") {
 	GlobalEvents.registerHandler("onBadRequest", (player, message) => {
-		Log.Warn(`Bad request from ${player.Name}: ${message}`);
+		Log.Warn(`Bad request from ${player.UserId}: ${message}`);
 	});
 
 	GlobalFunctions.registerHandler("onBadResponse", (player, message) => {
-		Log.Warn(`Bad response from ${player.Name}: ${message}`);
+		Log.Warn(`Bad response from ${player.UserId}: ${message}`);
 	});
 }

src/server/player/character/character-service.ts

@@ -84,7 +84,7 @@ export default class CharacterService implements OnStart, OnPlayerJoin {
 		return (player: Player, ...args: T): R | undefined => {
 			const playerRig = this.getCharacterRig(player);
 			if (!playerRig) {
-				this.logger.Info(`Could not get character rig for ${player.Name}`);
+				this.logger.Info(`Could not get character rig for ${player.UserId}`);
 				return;
 			}
 
@@ -118,7 +118,7 @@ export default class CharacterService implements OnStart, OnPlayerJoin {
 		connection.Disconnect();
 
 		if (!success) {
-			throw `Could not get character rig for ${player.Name}`;
+			throw `Could not get character rig for ${player.UserId}`;
 		}
 
 		this.listenForCharacterRemoving(player, model);
@@ -180,7 +180,7 @@ export default class CharacterService implements OnStart, OnPlayerJoin {
 	}
 
 	private async retryCharacterLoad(player: Player): Promise<void> {
-		this.logger.Warn(`Getting full rig for ${player.Name} timed out. Retrying...`);
+		this.logger.Warn(`Getting full rig for ${player.UserId} timed out. Retrying...`);
 		return loadCharacter(player);
 	}
 }

src/server/player/player-removal-service.ts

@@ -15,7 +15,7 @@ export default class PlayerRemovalService {
 	 * @param code - The reason the player was removed.
 	 */
 	public removeForBug(player: Player, code: KickCode): void {
-		this.logger.Warn(`Removing ${player.Name} due to bug: ${this.toMessage(code)}`);
+		this.logger.Warn(`Removing ${player.UserId} due to bug: ${this.toMessage(code)}`);
 		player.Kick(this.toMessage(code));
 	}