Skip to content

Commit 156dfee

Browse files
refactor: move logging to use userId over player name
1 parent c1cd5ad commit 156dfee

File tree

4 files changed

+8
-8
lines changed

4 files changed

+8
-8
lines changed

src/client/network.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -13,10 +13,10 @@ export const Functions = GlobalFunctions.createClient({
1313
// Log warnings for bad requests and responses in development
1414
if ($NODE_ENV === "development") {
1515
GlobalEvents.registerHandler("onBadRequest", (player, message) => {
16-
Log.Warn(`Bad request from ${player.Name}: ${message}`);
16+
Log.Warn(`Bad request from ${player.UserId}: ${message}`);
1717
});
1818

1919
GlobalFunctions.registerHandler("onBadResponse", (player, message) => {
20-
Log.Warn(`Bad response from ${player.Name}: ${message}`);
20+
Log.Warn(`Bad response from ${player.UserId}: ${message}`);
2121
});
2222
}

src/server/network.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -12,10 +12,10 @@ export const Functions = GlobalFunctions.createServer({
1212

1313
if ($NODE_ENV === "development") {
1414
GlobalEvents.registerHandler("onBadRequest", (player, message) => {
15-
Log.Warn(`Bad request from ${player.Name}: ${message}`);
15+
Log.Warn(`Bad request from ${player.UserId}: ${message}`);
1616
});
1717

1818
GlobalFunctions.registerHandler("onBadResponse", (player, message) => {
19-
Log.Warn(`Bad response from ${player.Name}: ${message}`);
19+
Log.Warn(`Bad response from ${player.UserId}: ${message}`);
2020
});
2121
}

src/server/player/character/character-service.ts

+3-3
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,7 @@ export default class CharacterService implements OnStart, OnPlayerJoin {
8484
return (player: Player, ...args: T): R | undefined => {
8585
const playerRig = this.getCharacterRig(player);
8686
if (!playerRig) {
87-
this.logger.Info(`Could not get character rig for ${player.Name}`);
87+
this.logger.Info(`Could not get character rig for ${player.UserId}`);
8888
return;
8989
}
9090

@@ -118,7 +118,7 @@ export default class CharacterService implements OnStart, OnPlayerJoin {
118118
connection.Disconnect();
119119

120120
if (!success) {
121-
throw `Could not get character rig for ${player.Name}`;
121+
throw `Could not get character rig for ${player.UserId}`;
122122
}
123123

124124
this.listenForCharacterRemoving(player, model);
@@ -180,7 +180,7 @@ export default class CharacterService implements OnStart, OnPlayerJoin {
180180
}
181181

182182
private async retryCharacterLoad(player: Player): Promise<void> {
183-
this.logger.Warn(`Getting full rig for ${player.Name} timed out. Retrying...`);
183+
this.logger.Warn(`Getting full rig for ${player.UserId} timed out. Retrying...`);
184184
return loadCharacter(player);
185185
}
186186
}

src/server/player/player-removal-service.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ export default class PlayerRemovalService {
1515
* @param code - The reason the player was removed.
1616
*/
1717
public removeForBug(player: Player, code: KickCode): void {
18-
this.logger.Warn(`Removing ${player.Name} due to bug: ${this.toMessage(code)}`);
18+
this.logger.Warn(`Removing ${player.UserId} due to bug: ${this.toMessage(code)}`);
1919
player.Kick(this.toMessage(code));
2020
}
2121

0 commit comments

Comments
 (0)