Skip to content

Commit 6aab3e3

Browse files
authored
refactor(detection_by_tracker): add package name prefix of autoware_ (autowarefoundation#7998)
Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
1 parent a8ea14e commit 6aab3e3

17 files changed

+12
-12
lines changed

.github/CODEOWNERS

+1-1
Original file line numberDiff line numberDiff line change
@@ -117,7 +117,7 @@ perception/autoware_cluster_merger/** dai.nguyen@tier4.jp shunsuke.miura@tier4.j
117117
perception/compare_map_segmentation/** abrahammonrroy@yahoo.com dai.nguyen@tier4.jp yukihiro.saito@tier4.jp
118118
perception/detected_object_feature_remover/** tomoya.kimura@tier4.jp
119119
perception/detected_object_validation/** dai.nguyen@tier4.jp shintaro.tomie@tier4.jp shunsuke.miura@tier4.jp yoshi.ri@tier4.jp yukihiro.saito@tier4.jp
120-
perception/detection_by_tracker/** taekjin.lee@tier4.jp yoshi.ri@tier4.jp yukihiro.saito@tier4.jp
120+
perception/autoware_detection_by_tracker/** taekjin.lee@tier4.jp yoshi.ri@tier4.jp yukihiro.saito@tier4.jp
121121
perception/elevation_map_loader/** kosuke.takeuchi@tier4.jp shintaro.tomie@tier4.jp taichi.higashide@tier4.jp
122122
perception/euclidean_cluster/** dai.nguyen@tier4.jp yukihiro.saito@tier4.jp
123123
perception/ground_segmentation/** abrahammonrroy@yahoo.com dai.nguyen@tier4.jp shunsuke.miura@tier4.jp yoshi.ri@tier4.jp yukihiro.saito@tier4.jp

launch/tier4_perception_launch/launch/object_recognition/detection/detector/tracker_based_detector.launch.xml

+2-2
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,8 @@
33
<arg name="output/objects"/>
44
<!-- DetectionByTracker -->
55
<group>
6-
<push-ros-namespace namespace="detection_by_tracker"/>
7-
<include file="$(find-pkg-share detection_by_tracker)/launch/detection_by_tracker.launch.xml">
6+
<push-ros-namespace namespace="autoware_detection_by_tracker"/>
7+
<include file="$(find-pkg-share autoware_detection_by_tracker)/launch/detection_by_tracker.launch.xml">
88
<arg name="detection_by_tracker_param_path" value="$(var object_recognition_detection_detection_by_tracker_param)"/>
99
<arg name="output" value="$(var output/objects)"/>
1010
</include>

launch/tier4_perception_launch/package.xml

+1-1
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@
1515

1616
<exec_depend>autoware_cluster_merger</exec_depend>
1717
<exec_depend>autoware_crosswalk_traffic_light_estimator</exec_depend>
18+
<exec_depend>autoware_detection_by_tracker</exec_depend>
1819
<exec_depend>autoware_map_based_prediction</exec_depend>
1920
<exec_depend>autoware_object_range_splitter</exec_depend>
2021
<exec_depend>autoware_object_velocity_splitter</exec_depend>
@@ -26,7 +27,6 @@
2627
<exec_depend>compare_map_segmentation</exec_depend>
2728
<exec_depend>detected_object_feature_remover</exec_depend>
2829
<exec_depend>detected_object_validation</exec_depend>
29-
<exec_depend>detection_by_tracker</exec_depend>
3030
<exec_depend>elevation_map_loader</exec_depend>
3131
<exec_depend>euclidean_cluster</exec_depend>
3232
<exec_depend>ground_segmentation</exec_depend>

perception/detection_by_tracker/CMakeLists.txt perception/autoware_detection_by_tracker/CMakeLists.txt

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
cmake_minimum_required(VERSION 3.14)
2-
project(detection_by_tracker)
2+
project(autoware_detection_by_tracker)
33

44
find_package(autoware_cmake REQUIRED)
55
autoware_package()

perception/detection_by_tracker/README.md perception/autoware_detection_by_tracker/README.md

+3-3
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,16 @@
1-
# detection_by_tracker
1+
# autoware_detection_by_tracker
22

33
## Purpose
44

55
This package feeds back the tracked objects to the detection module to keep it stable and keep detecting objects.
66
![purpose](image/purpose.svg)
77

8-
The detection by tracker takes as input an unknown object containing a cluster of points and a tracker.
8+
The autoware detection by tracker takes as input an unknown object containing a cluster of points and a tracker.
99
The unknown object is optimized to fit the size of the tracker so that it can continue to be detected.
1010

1111
## Inner-workings / Algorithms
1212

13-
The detection by tracker receives an unknown object containing a point cloud and a tracker, where the unknown object is mainly shape-fitted using euclidean clustering.
13+
The autoware detection by tracker receives an unknown object containing a point cloud and a tracker, where the unknown object is mainly shape-fitted using euclidean clustering.
1414
Shape fitting using euclidean clustering and other methods has a problem called under segmentation and over segmentation.
1515

1616
[![segmentation_fail](image/segmentation_fail.png)](https://www.researchgate.net/figure/Examples-of-an-undersegmentation-error-top-and-an-oversegmentation-error-bottom-Each_fig1_304533062)

perception/detection_by_tracker/launch/detection_by_tracker.launch.xml perception/autoware_detection_by_tracker/launch/detection_by_tracker.launch.xml

+2-2
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,8 @@
33
<arg name="input/tracked_objects" default="/perception/object_recognition/tracking/objects"/>
44
<arg name="input/initial_objects" default="/perception/object_recognition/detection/clustering/objects_with_feature"/>
55
<arg name="output" default="objects"/>
6-
<arg name="detection_by_tracker_param_path" default="$(find-pkg-share detection_by_tracker)/config/detection_by_tracker.param.yaml"/>
7-
<node pkg="detection_by_tracker" exec="detection_by_tracker_node" name="detection_by_tracker_node" output="screen">
6+
<arg name="detection_by_tracker_param_path" default="$(find-pkg-share autoware_detection_by_tracker)/config/detection_by_tracker.param.yaml"/>
7+
<node pkg="autoware_detection_by_tracker" exec="detection_by_tracker_node" name="detection_by_tracker_node" output="screen">
88
<remap from="~/input/tracked_objects" to="$(var input/tracked_objects)"/>
99
<remap from="~/input/initial_objects" to="$(var input/initial_objects)"/>
1010
<remap from="~/output" to="$(var output)"/>

perception/detection_by_tracker/package.xml perception/autoware_detection_by_tracker/package.xml

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
11
<?xml version="1.0"?>
22
<?xml-model href="http://download.ros.org/schema/package_format3.xsd" schematypens="http://www.w3.org/2001/XMLSchema"?>
33
<package format="3">
4-
<name>detection_by_tracker</name>
4+
<name>autoware_detection_by_tracker</name>
55
<version>1.0.0</version>
6-
<description>The ROS 2 detection_by_tracker package</description>
6+
<description>The ROS 2 autoware_detection_by_tracker package</description>
77
<maintainer email="yukihiro.saito@tier4.jp">Yukihiro Saito</maintainer>
88
<maintainer email="yoshi.ri@tier4.jp">Yoshi Ri</maintainer>
99
<maintainer email="taekjin.lee@tier4.jp">Taekjin Lee</maintainer>

0 commit comments

Comments
 (0)