Skip to content

Commit 8044786

Browse files
committed
Last touches
Type: review
1 parent 675bca0 commit 8044786

File tree

4 files changed

+11
-11
lines changed

4 files changed

+11
-11
lines changed

README.md

+3-3
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ The goal of this project was get additional practice with:
2121
__Notes:__
2222

2323
- During the process of creating these I came to conclude that some of the previously generated code was not needed, so that will find some code that is not existant at later branches.
24-
- In order to run the code you will require node version 11.15.0 and nvm version 1.1.8.
24+
- In order to run the code you will require node version **11.15.0** and nvm version **1.1.8**.
2525
- Also you will have to create a .env file with your API Keys for the different APIs.
2626

2727
## Available Documentation
@@ -51,5 +51,5 @@ Here you will find detailed information as to the steps and notes from the Udaci
5151
2. Understanding that I had to use the right node.js and npm versions.
5252
3. Understanding that I had to downgrade the different package versions of plugins and loaders and not just install the latest versions which are installed by default.
5353
4. Realizing that we did not have to follow exactly the boiler plate api fetch template from MeaningCloud.
54-
5. Learning to do testing.
55-
6. Incorporating new features.
54+
5. Learning to do basic testing.
55+
6. Incorporating new features, like creating a database and consult, update and deleting from it.

documentation/UDACITY_Project_Rubric.md

+3-3
Original file line numberDiff line numberDiff line change
@@ -26,9 +26,9 @@ The project should have a structure like the one shown below. All files shown mu
2626

2727
### Testing
2828

29-
-[] Check if Jest has been installed and npm run test script is implemented to run Jest.
30-
-[] There should be at least one test for the express server.
31-
-[] There should be at least one test for the application javascript client.
29+
-[x] Check if Jest has been installed and npm run test script is implemented to run Jest.
30+
-[x] There should be at least one test for the express server.
31+
-[x] There should be at least one test for the application javascript client.
3232

3333
### Offline capabilities
3434

src/client/styles/base.scss

+1-1
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ a {
4444
}
4545

4646
a:hover {
47-
color: rgb(71, 163, 71);
47+
color: rgb(162, 209, 162);
4848
font-style: italic;
4949
font-weight: 700;
5050
}

src/client/styles/form.scss

+4-4
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ input {
1919
}
2020

2121
input:hover {
22-
background-color: rgb(71, 163, 71);
22+
background-color: rgb(162, 209, 162);
2323
}
2424

2525

@@ -34,7 +34,7 @@ form textarea {
3434
}
3535

3636
textarea:hover {
37-
background-color: rgb(71, 163, 71);
37+
background-color: rgb(162, 209, 162);
3838
}
3939

4040
//---------------- NEW Project 05----
@@ -234,7 +234,7 @@ button {
234234
}
235235

236236
button:hover {
237-
background-color: rgb(71, 163, 71);
237+
background-color: rgb(162, 209, 162);
238238
}
239239

240240

@@ -254,7 +254,7 @@ button:hover {
254254
// Saved Trip Log
255255

256256
.trip_saved:hover {
257-
background-color: rgb(67, 120, 185);
257+
background-color: rgb(162, 209, 162);
258258
color: white;
259259
}
260260

0 commit comments

Comments
 (0)