feat: add pipeline metrics #646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds metrics for the pipeline system. Support was added to the actor framework to directly support metrics.
nathanielc
requested review from
sam701 and
dav1do
and removed request for
a team
nathanielc
temporarily deployed
to
dev-qa-2024
GitHub Actions
Inactive
dav1do
approved these changes
Jan 22, 2025
actor/src/macros.rs
Outdated
| pub trait $trait_name : $crate::Actor<Envelope = $enum_name> $( + $crate::Handler<$message_type> )* { } | ||
| pub trait $actor_trait : $crate::Actor<Envelope = $enum_name> $( + $crate::Handler<$message_type> )* + ::std::marker::Send + 'static { } | ||
|
|
||
| #[doc = std::stringify!($actor_trait)] |
There was a problem hiding this comment.
this should be$recorder_trait
| mut shutdown: ShutdownSignal, | ||
| ) -> anyhow::Result<()> { | ||
| let mut interval = interval(Duration::from_millis(1_000)); | ||
| interval.set_missed_tick_behavior(MissedTickBehavior::Skip); |
nathanielc
temporarily deployed
to
dev-qa-2024
GitHub Actions
Inactive
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds metrics for the pipeline system. Support was added to the actor framework to directly support metrics.
Fixes #582