Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reject unsigned init events with data for MID/model stream types #655

Open
dav1do opened this issue Jan 29, 2025 · 0 comments
Open

Reject unsigned init events with data for MID/model stream types #655

dav1do opened this issue Jan 29, 2025 · 0 comments

Comments

@dav1do
Copy link
Contributor

dav1do commented Jan 29, 2025

Description

Currently, an unsigned init event with data will be successfully store and validate. This should be rejected as MID and Model stream types require init events with data are signed. We actually have a test for one of these explicitly, as it was found in the wild (see #404), but it must have been created at a strange time as it would no longer be accepted by js-ceramic.

Technical Information

The event builder should prevent creating these types of events, but the HTTP/recon APIs are currently less strict.

Not entirely sure where this should live, we could enforce it in decode_car, or in the initial (signature/history) validation logic, or in the pipeline (schema validation).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant