Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

diff-hl indicators not shown in fringe #185

Closed
gekoke opened this issue Aug 27, 2024 · 3 comments
Closed

diff-hl indicators not shown in fringe #185

gekoke opened this issue Aug 27, 2024 · 3 comments

Comments

@gekoke
Copy link

gekoke commented Aug 27, 2024

With catppuccin-theme (mocha variant):

image

WIth modus-vivendi:

image
gekoke added a commit to gekoke/dotfiles that referenced this issue Aug 27, 2024
@gekoke
Revert "feat(emacs): add catppuccin-theme"
fc59e2c 
It's broken with diff-hl, see catppuccin/emacs#185
jtbx added a commit that referenced this issue Aug 27, 2024
@jtbx
fix: improve diff-hl gutter readability
851bb08 
Closes #185
@jtbx
Copy link
Member

jtbx commented Aug 27, 2024

I've made #186, would you be able to test that out? On my Emacs I can at least see a thin border around the gutter indicators but that should set a concrete colour for the whole thing.

gekoke added a commit to gekoke/dotfiles that referenced this issue Aug 28, 2024
@gekoke
Revert "feat(emacs): add catppuccin-theme"
f87c8d6 
It's broken with diff-hl, see catppuccin/emacs#185
@gekoke
Copy link
Author

gekoke commented Aug 28, 2024 •
edited
Loading

Yes, that works for me - looks the same as in the image attached to the PR.

@jtbx
Copy link
Member

jtbx commented Aug 28, 2024

Neat, thanks!

@jtbx jtbx closed this as completed in fe83fa1 Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gekoke @jtbx