-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error in DecoratorController of metacontroller rock: failed to sync kubeflow-pipelines-profile-controller
#157
Comments
Thank you for reporting your feedback to us! The internal ticket has been created: https://warthogs.atlassian.net/browse/KF-7099.
|
Thanks for reporting this. Reproducing the issueThe test case you mention in the description of this issue is
This secret is requested by the I tried reproducing the issue locally and in fact I wasn't able to see the secrets (or service accounts) that
Though I can see the resource dispatcher
What's causing the issue?I believe this issue is caused by 5e1ddb8 as it removed this
We can see that's the case because now the You can check this by running:
Important to note: the FixEither bring back the very permissive ObservationsAfter applying the following diff on diffdiff --git a/src/files/manifests/metacontroller-rbac.yaml b/src/files/manifests/metacontroller-rbac.yaml
index 20b0b2d..d5717f0 100644
--- a/src/files/manifests/metacontroller-rbac.yaml
+++ b/src/files/manifests/metacontroller-rbac.yaml
@@ -14,102 +14,11 @@ metadata:
name: {{ namespace }}-{{ app_name }}-charm
rules:
- apiGroups:
- - ""
+ - "*"
resources:
- - namespaces
+ - "*"
verbs:
- - get
- - list
- - watch
- - update
-- apiGroups:
- - ""
- resources:
- - namespaces/status
- verbs:
- - get
- - list
- - watch
- - update
- - patch
-- apiGroups:
- - ""
- resources:
- - secrets
- - configmaps
- verbs:
- - get
- - list
- - watch
- - create
- - update
- - patch
- - delete
-- apiGroups:
- - apps
- resources:
- - deployments
- verbs:
- - get
- - list
- - watch
- - create
- - update
- - patch
- - delete
-- apiGroups:
- - ""
- resources:
- - services
- verbs:
- - get
- - list
- - watch
- - create
- - update
- - patch
- - delete
-- apiGroups:
- - networking.istio.io
- resources:
- - destinationrules
- verbs:
- - get
- - list
- - watch
- - create
- - update
- - patch
- - delete
-- apiGroups:
- - security.istio.io
- resources:
- - authorizationpolicies
- verbs:
- - get
- - list
- - watch
- - create
- - update
- - patch
- - delete
-- apiGroups:
- - metacontroller.k8s.io
- resources:
- - compositecontrollers
- - controllerrevisions
- - decoratorcontrollers
- verbs:
- - get
- - list
- - watch
-- apiGroups:
- - ""
- resources:
- - events
- verbs:
- - create
- - patch
+ - "*"
---
apiVersion: rbac.authorization.k8s.io/v1
kind: ClusterRoleBinding
Not sure if this is causing another issue, but it seems to be preventing the resources to be created:
|
@DnPlas thank you for the thorough exploration! It's not clear to me though why we get 404 for the secret, since the manifests were giving permissions for secrets: metacontroller-operator/src/files/manifests/metacontroller-rbac.yaml Lines 35 to 47 in ce36513
For the PodDefaults and ServiceAccounts it makes sense, since those permissions were removed. |
When I was doing the exploration, it looked like the |
Can confirm that by adding permissions for Also the secrets for MLflow's MinIO and So I'll send a PR with including only those (and a comment so we don't accidentally remove them in the future) and avoid the |
Bug Description
This issue occurred while running the integration tests for
kserve-operators
To Reproduce
kserve-operators
repolightkube.core.exceptions.ApiError: secrets "kserve-controller-s3" not found
Environment
v4.11.22
Relevant Log Output
Additional Context
This issue seems related to the upgrade of the
metacontroller
rock: canonical/metacontroller-rock#24The text was updated successfully, but these errors were encountered: