Move individual charms to building from local libraries

Author: UtkarshBhatthere

.github/workflows/build-and-test.yml

@@ -96,6 +96,7 @@ jobs:
         id: builder
         run: |
           sudo snap install charmcraft --classic
+          # expects the local libraries to be already available in $charm/lib as it was done for unit tests.
           tox -c ${{ matrix.part }} -e build
 
       - name: Upload built charm

ceph-dashboard/requirements.txt

@@ -1,7 +1,8 @@
 importlib-resources
 ops >= 1.2.0, <= 1.5.2
 tenacity
-git+https://github.com/openstack/charms.ceph#egg=charms_ceph
+./lib/charms.ceph
+git+https://github.com/canonical/cos-lib # for ceph_metrics
 git+https://opendev.org/openstack/charm-ops-openstack#egg=ops_openstack
 git+https://opendev.org/openstack/charm-ops-interface-tls-certificates#egg=interface_tls_certificates
 git+https://github.com/openstack-charmers/ops-interface-ceph-iscsi-admin-access#egg=interface_ceph_iscsi_admin_access

ceph-mon/charmcraft.yaml

@@ -9,6 +9,8 @@ parts:
     - setuptools
     build-packages:
     - git
+    - cargo
+    - rustc
 
   update-certificates:
     # Ensure that certificates in the base image are up-to-date.

ceph-mon/requirements.txt

@@ -6,9 +6,12 @@ dnspython
 netaddr
 netifaces
 pyyaml
+cosl==0.0.55
+
 # the build process expects charms.ceph and charms.ceph_metrics be at lib/ inside the charm directory.
 ./lib/charms.ceph_metrics
 ./lib/charms.ceph
+
 git+https://opendev.org/openstack/charm-ops-openstack#egg=ops_openstack
 git+https://opendev.org/openstack/charm-ops-interface-tls-certificates#egg=interface_tls_certificates
 git+https://github.com/openstack-charmers/ops-interface-ceph-iscsi-admin-access#egg=interface_ceph_iscsi_admin_access

charm_utils.sh

@@ -1,22 +1,14 @@
 #!/bin/bash
 
-function build() {
-  local charm="${1?missing}"
-
-  # remove old and copy fresh dependencies into lib dir.
-  rm -rf $charm/lib/charms.ceph*
-  cp -r ./charms.ceph* $charm/lib/
-
-  cd $charm
-  tox -e build
-}
-
 function copy_libs() {
   local charm="${1?missing}"
 
-  # remove old and copy fresh dependencies into lib dir.
-  rm -rf $charm/lib/charms.ceph*
+   # remove old copy of local libraries may fail if lib folder does not exist. 
+  rm -rf $charm/lib/charms.ceph* || true
+  # create a lib folder in case it does not exist
+  mkdir -p $charm/lib
   cp -r ./charms.ceph* $charm/lib/
+
 }
 
 function clean() {

charms.ceph_metrics/requirements.txt

@@ -1,7 +1,7 @@
 # Requirements for ceph_metrics dependencies
 ops >= 1.2.0
 tenacity
+cosl==0.0.55
+
 # the build process expects charms.ceph and charms.ceph_metrics be at lib/ inside the charm directory.
 ../charms.ceph # charms.ceph from local repository
-
-git+https://github.com/canonical/cos-lib