Skip to content

Commit 5f54a08

Browse files
committed
do not break if targets scraping failed
1 parent b1f194c commit 5f54a08

File tree

2 files changed

+3
-4
lines changed

2 files changed

+3
-4
lines changed

main.go

+2-3
Original file line numberDiff line numberDiff line change
@@ -115,7 +115,7 @@ func getTargets() (c []byte, err error) {
115115

116116
nodes, err := getNodes(client, cfg.PuppetDBURL, cfg.Query)
117117
if err != nil {
118-
log.Errorf("failed to get nodes: %v", err)
118+
err = fmt.Errorf("failed to get nodes: %v", err)
119119
return
120120
}
121121

@@ -125,7 +125,7 @@ func getTargets() (c []byte, err error) {
125125
// TODO: Remove backward compatibility
126126
t, err := extractTargets(targets)
127127
if err != nil {
128-
log.Errorf("failed to extract targets: %s", err)
128+
err = fmt.Errorf("failed to extract targets: %s", err)
129129
return nil, err
130130
}
131131

@@ -330,7 +330,6 @@ func main() {
330330
c, err := getTargets()
331331
if err != nil {
332332
log.Errorf("failed to get exporters: %v", err)
333-
break
334333
}
335334

336335
configMap := &v1.ConfigMap{

prometheus-puppetdb.1

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
.TH prometheus-puppetdb 1 "26 June 2018"
1+
.TH prometheus-puppetdb 1 "30 October 2018"
22
.SH NAME
33
prometheus-puppetdb \- Prometheus scrape lists based on PuppetDB
44
.SH SYNOPSIS

0 commit comments

Comments
 (0)