add static checks

Author: cryptobioz

Makefile

@@ -1,7 +1,7 @@
 DEPS = $(wildcard */*/*/*.go)
 VERSION = $(shell git describe --always --dirty)
 
-all: lint vet test prometheus-puppetdb prometheus-puppetdb.1
+all: lint test prometheus-puppetdb prometheus-puppetdb.1
 
 prometheus-puppetdb: main.go $(DEPS)
 	GO111MODULE=on CGO_ENABLED=0 GOOS=linux \
@@ -17,16 +17,16 @@ clean:
 	rm -f prometheus-puppetdb prometheus-puppetdb.1
 
 lint:
-	@ go get -v golang.org/x/lint/golint
+	go vet $<
+	@GO111MODULE=off go get -u honnef.co/go/tools/cmd/staticcheck
+	staticcheck -tests ./...
+	@GO111MODULE=off go get -u golang.org/x/lint/golint
 	@for file in $$(go list ./... | grep -v '_workspace/' | grep -v 'vendor'); do \
 		export output="$$(golint $${file} | grep -v 'type name will be used as docker.DockerInfo')"; \
 		[ -n "$${output}" ] && echo "$${output}" && export status=1; \
 	done; \
 	exit $${status:-0}
 
-vet: main.go
-	go vet $<
-
 vendor:
 	go mod vendor