Skip to content

Commit 68de0b7

Browse files
rcaplierRomuald Caplier
and
Romuald Caplier
authored
refactor(geocat): removed the metadata-catalog component (#18)
Co-authored-by: Romuald Caplier <romuald.caplier@camptocamp.com>
1 parent 2072ba1 commit 68de0b7

8 files changed

+0
-86
lines changed

apps/datahub/src/app/record/record-metadata/record-metadata.component.html

-2
Original file line numberDiff line numberDiff line change
@@ -44,8 +44,6 @@
4444
[metadataQualityDisplay]="metadataQualityDisplay"
4545
></gn-ui-metadata-quality>
4646
</div>
47-
<gn-ui-metadata-catalog [sourceLabel]="sourceLabel$ | async">
48-
</gn-ui-metadata-catalog>
4947
</div>
5048
</div>
5149
</div>

apps/datahub/src/app/record/record-metadata/record-metadata.component.spec.ts

-25
Original file line numberDiff line numberDiff line change
@@ -132,15 +132,6 @@ export class MockMetadataContactComponent {
132132
@Output() contactClick = new EventEmitter<Individual>()
133133
}
134134

135-
@Component({
136-
// eslint-disable-next-line @angular-eslint/component-selector
137-
selector: 'gn-ui-metadata-catalog',
138-
template: '<div></div>',
139-
})
140-
export class MockMetadataCatalogComponent {
141-
@Input() sourceLabel: string
142-
}
143-
144135
@Component({
145136
// eslint-disable-next-line @angular-eslint/component-selector
146137
selector: 'gn-ui-record-api-form',
@@ -179,7 +170,6 @@ describe('RecordMetadataComponent', () => {
179170
MockRelatedComponent,
180171
SearchResultsErrorComponent,
181172
MockMetadataInfoComponent,
182-
MockMetadataCatalogComponent,
183173
MockMetadataContactComponent,
184174
MockRecordApiFormComponent,
185175
MockImgOverlayPreviewComponent,
@@ -227,7 +217,6 @@ describe('RecordMetadataComponent', () => {
227217
describe('about', () => {
228218
let metadataInfo: MockMetadataInfoComponent
229219
let metadataContact: MockMetadataContactComponent
230-
let catalogComponent: MockMetadataCatalogComponent
231220

232221
beforeEach(() => {
233222
facade.isPresent$.next(true)
@@ -238,9 +227,6 @@ describe('RecordMetadataComponent', () => {
238227
metadataContact = fixture.debugElement.query(
239228
By.directive(MockMetadataContactComponent)
240229
).componentInstance
241-
catalogComponent = fixture.debugElement.query(
242-
By.directive(MockMetadataCatalogComponent)
243-
).componentInstance
244230
})
245231
describe('if metadata present', () => {
246232
it('shows the full metadata', () => {
@@ -249,12 +235,6 @@ describe('RecordMetadataComponent', () => {
249235
it('shows the metadata contact', () => {
250236
expect(metadataContact.metadata).toHaveProperty('contacts')
251237
})
252-
it('shows the metadata catalog', () => {
253-
expect(sourcesService.getSourceLabel).toBeCalledWith(
254-
SAMPLE_RECORD.extras.catalogUuid
255-
)
256-
expect(catalogComponent.sourceLabel).toEqual('catalog label')
257-
})
258238
})
259239
describe('if metadata not present', () => {
260240
beforeEach(() => {
@@ -273,11 +253,6 @@ describe('RecordMetadataComponent', () => {
273253
fixture.debugElement.query(By.directive(MockMetadataContactComponent))
274254
).toBeFalsy()
275255
})
276-
it('does not display the metadata catalog component', () => {
277-
expect(
278-
fixture.debugElement.query(By.directive(MockMetadataCatalogComponent))
279-
).toBeFalsy()
280-
})
281256
it('does not display the image overlay preview', () => {
282257
expect(
283258
fixture.debugElement.query(

libs/ui/elements/src/index.ts

-1
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
export * from './lib/ui-elements.module'
22
export * from './lib/metadata-info/metadata-info.component'
33
export * from './lib/metadata-contact/metadata-contact.component'
4-
export * from './lib/metadata-catalog/metadata-catalog.component'
54
export * from './lib/metadata-quality/metadata-quality.component'
65
export * from './lib/metadata-quality-item/metadata-quality-item.component'
76
export * from './lib/search-results-error/search-results-error.component'

libs/ui/elements/src/lib/metadata-catalog/metadata-catalog.component.css

Whitespace-only changes.

libs/ui/elements/src/lib/metadata-catalog/metadata-catalog.component.html

-8
This file was deleted.

libs/ui/elements/src/lib/metadata-catalog/metadata-catalog.component.spec.ts

-36
This file was deleted.

libs/ui/elements/src/lib/metadata-catalog/metadata-catalog.component.ts

-11
This file was deleted.

libs/ui/elements/src/lib/ui-elements.module.ts

-3
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@ import { TranslateModule } from '@ngx-translate/core'
1515
import { LinkCardComponent } from './link-card/link-card.component'
1616
import { RelatedRecordCardComponent } from './related-record-card/related-record-card.component'
1717
import { MetadataContactComponent } from './metadata-contact/metadata-contact.component'
18-
import { MetadataCatalogComponent } from './metadata-catalog/metadata-catalog.component'
1918
import { MetadataQualityComponent } from './metadata-quality/metadata-quality.component'
2019
import { MetadataQualityItemComponent } from './metadata-quality-item/metadata-quality-item.component'
2120
import { SearchResultsErrorComponent } from './search-results-error/search-results-error.component'
@@ -56,7 +55,6 @@ import { ImageOverlayPreviewComponent } from './image-overlay-preview/image-over
5655
LinkCardComponent,
5756
RelatedRecordCardComponent,
5857
MetadataContactComponent,
59-
MetadataCatalogComponent,
6058
MetadataQualityComponent,
6159
MetadataQualityItemComponent,
6260
SearchResultsErrorComponent,
@@ -79,7 +77,6 @@ import { ImageOverlayPreviewComponent } from './image-overlay-preview/image-over
7977
LinkCardComponent,
8078
RelatedRecordCardComponent,
8179
MetadataContactComponent,
82-
MetadataCatalogComponent,
8380
MetadataQualityComponent,
8481
MetadataQualityItemComponent,
8582
SearchResultsErrorComponent,

0 commit comments

Comments
 (0)