Skip to content

Commit 29d9726

Browse files
rcaplierRomuald Caplier
authored andcommitted
refactor(geocat): removed the metadata-catalog component (#18)
Co-authored-by: Romuald Caplier <romuald.caplier@camptocamp.com>
1 parent d6178d4 commit 29d9726

File tree

7 files changed

+8
-84
lines changed

7 files changed

+8
-84
lines changed

apps/datahub/src/app/record/record-metadata/record-metadata.component.spec.ts

-25
Original file line numberDiff line numberDiff line change
@@ -131,15 +131,6 @@ export class MockMetadataContactComponent {
131131
@Output() contactClick = new EventEmitter<Individual>()
132132
}
133133

134-
@Component({
135-
// eslint-disable-next-line @angular-eslint/component-selector
136-
selector: 'gn-ui-metadata-catalog',
137-
template: '<div></div>',
138-
})
139-
export class MockMetadataCatalogComponent {
140-
@Input() sourceLabel: string
141-
}
142-
143134
@Component({
144135
// eslint-disable-next-line @angular-eslint/component-selector
145136
selector: 'gn-ui-record-api-form',
@@ -178,7 +169,6 @@ describe('RecordMetadataComponent', () => {
178169
MockRelatedComponent,
179170
ErrorComponent,
180171
MockMetadataInfoComponent,
181-
MockMetadataCatalogComponent,
182172
MockMetadataContactComponent,
183173
MockRecordApiFormComponent,
184174
MockImgOverlayPreviewComponent,
@@ -226,7 +216,6 @@ describe('RecordMetadataComponent', () => {
226216
describe('about', () => {
227217
let metadataInfo: MockMetadataInfoComponent
228218
let metadataContact: MockMetadataContactComponent
229-
let catalogComponent: MockMetadataCatalogComponent
230219

231220
beforeEach(() => {
232221
facade.isPresent$.next(true)
@@ -237,9 +226,6 @@ describe('RecordMetadataComponent', () => {
237226
metadataContact = fixture.debugElement.query(
238227
By.directive(MockMetadataContactComponent)
239228
).componentInstance
240-
catalogComponent = fixture.debugElement.query(
241-
By.directive(MockMetadataCatalogComponent)
242-
).componentInstance
243229
})
244230
describe('if metadata present', () => {
245231
it('shows the full metadata', () => {
@@ -248,12 +234,6 @@ describe('RecordMetadataComponent', () => {
248234
it('shows the metadata contact', () => {
249235
expect(metadataContact.metadata).toHaveProperty('contacts')
250236
})
251-
it('shows the metadata catalog', () => {
252-
expect(sourcesService.getSourceLabel).toBeCalledWith(
253-
SAMPLE_RECORD.extras.catalogUuid
254-
)
255-
expect(catalogComponent.sourceLabel).toEqual('catalog label')
256-
})
257237
})
258238
describe('if metadata not present', () => {
259239
beforeEach(() => {
@@ -272,11 +252,6 @@ describe('RecordMetadataComponent', () => {
272252
fixture.debugElement.query(By.directive(MockMetadataContactComponent))
273253
).toBeFalsy()
274254
})
275-
it('does not display the metadata catalog component', () => {
276-
expect(
277-
fixture.debugElement.query(By.directive(MockMetadataCatalogComponent))
278-
).toBeFalsy()
279-
})
280255
it('does not display the image overlay preview', () => {
281256
expect(
282257
fixture.debugElement.query(

libs/ui/elements/src/index.ts

+8-1
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,11 @@
1+
export * from './lib/ui-elements.module'
2+
export * from './lib/metadata-info/metadata-info.component'
3+
export * from './lib/metadata-contact/metadata-contact.component'
4+
export * from './lib/metadata-quality/metadata-quality.component'
5+
export * from './lib/metadata-quality-item/metadata-quality-item.component'
6+
export * from './lib/thumbnail/thumbnail.component'
7+
export * from './lib/content-ghost/content-ghost.component'
8+
export * from './lib/pagination-buttons/pagination-buttons.component'
19
export * from './lib/api-card/api-card.component'
210
export * from './lib/avatar/avatar.component'
311
export * from './lib/confirmation-dialog/confirmation-dialog.component'
@@ -9,7 +17,6 @@ export * from './lib/image-overlay-preview/image-overlay-preview.component'
917
export * from './lib/link-card/link-card.component'
1018
export * from './lib/markdown-editor/markdown-editor.component'
1119
export * from './lib/markdown-parser/markdown-parser.component'
12-
export * from './lib/metadata-catalog/metadata-catalog.component'
1320
export * from './lib/metadata-contact/metadata-contact.component'
1421
export * from './lib/metadata-info/metadata-info.component'
1522
export * from './lib/metadata-quality-item/metadata-quality-item.component'

libs/ui/elements/src/lib/metadata-catalog/metadata-catalog.component.css

Whitespace-only changes.

libs/ui/elements/src/lib/metadata-catalog/metadata-catalog.component.html

-8
This file was deleted.

libs/ui/elements/src/lib/metadata-catalog/metadata-catalog.component.spec.ts

-36
This file was deleted.

libs/ui/elements/src/lib/metadata-catalog/metadata-catalog.component.ts

-11
This file was deleted.

libs/ui/elements/src/lib/ui-elements.module.ts

-3
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@ import { MaxLinesComponent, UiLayoutModule } from '@geonetwork-ui/ui/layout'
1313
import { TranslateModule } from '@ngx-translate/core'
1414
import { RelatedRecordCardComponent } from './related-record-card/related-record-card.component'
1515
import { MetadataContactComponent } from './metadata-contact/metadata-contact.component'
16-
import { MetadataCatalogComponent } from './metadata-catalog/metadata-catalog.component'
1716
import { MetadataQualityComponent } from './metadata-quality/metadata-quality.component'
1817
import { MetadataQualityItemComponent } from './metadata-quality-item/metadata-quality-item.component'
1918
import { ErrorComponent } from './error/error.component'
@@ -111,7 +110,6 @@ import { iconoirNavArrowRight, iconoirNavArrowLeft } from '@ng-icons/iconoir'
111110
ApiCardComponent,
112111
RelatedRecordCardComponent,
113112
MetadataContactComponent,
114-
MetadataCatalogComponent,
115113
MetadataQualityComponent,
116114
MetadataQualityItemComponent,
117115
ErrorComponent,
@@ -132,7 +130,6 @@ import { iconoirNavArrowRight, iconoirNavArrowLeft } from '@ng-icons/iconoir'
132130
ApiCardComponent,
133131
RelatedRecordCardComponent,
134132
MetadataContactComponent,
135-
MetadataCatalogComponent,
136133
MetadataQualityComponent,
137134
MetadataQualityItemComponent,
138135
ErrorComponent,

0 commit comments

Comments
 (0)