Skip to content

Commit 11b601b

Browse files
rcaplierRomuald Caplier
authored andcommitted
refactor(geocat): removed the metadata-catalog component (#18)
Co-authored-by: Romuald Caplier <romuald.caplier@camptocamp.com>
1 parent 42f8d1d commit 11b601b

8 files changed

+8
-86
lines changed

apps/datahub/src/app/record/record-metadata/record-metadata.component.html

-2
Original file line numberDiff line numberDiff line change
@@ -44,8 +44,6 @@
4444
[metadataQualityDisplay]="metadataQualityDisplay"
4545
></gn-ui-metadata-quality>
4646
</div>
47-
<gn-ui-metadata-catalog [sourceLabel]="sourceLabel$ | async">
48-
</gn-ui-metadata-catalog>
4947
</div>
5048
</div>
5149
</div>

apps/datahub/src/app/record/record-metadata/record-metadata.component.spec.ts

-25
Original file line numberDiff line numberDiff line change
@@ -130,15 +130,6 @@ export class MockMetadataContactComponent {
130130
@Output() contactClick = new EventEmitter<Individual>()
131131
}
132132

133-
@Component({
134-
// eslint-disable-next-line @angular-eslint/component-selector
135-
selector: 'gn-ui-metadata-catalog',
136-
template: '<div></div>',
137-
})
138-
export class MockMetadataCatalogComponent {
139-
@Input() sourceLabel: string
140-
}
141-
142133
@Component({
143134
// eslint-disable-next-line @angular-eslint/component-selector
144135
selector: 'gn-ui-record-api-form',
@@ -177,7 +168,6 @@ describe('RecordMetadataComponent', () => {
177168
MockRelatedComponent,
178169
ErrorComponent,
179170
MockMetadataInfoComponent,
180-
MockMetadataCatalogComponent,
181171
MockMetadataContactComponent,
182172
MockRecordApiFormComponent,
183173
MockImgOverlayPreviewComponent,
@@ -225,7 +215,6 @@ describe('RecordMetadataComponent', () => {
225215
describe('about', () => {
226216
let metadataInfo: MockMetadataInfoComponent
227217
let metadataContact: MockMetadataContactComponent
228-
let catalogComponent: MockMetadataCatalogComponent
229218

230219
beforeEach(() => {
231220
facade.isPresent$.next(true)
@@ -236,9 +225,6 @@ describe('RecordMetadataComponent', () => {
236225
metadataContact = fixture.debugElement.query(
237226
By.directive(MockMetadataContactComponent)
238227
).componentInstance
239-
catalogComponent = fixture.debugElement.query(
240-
By.directive(MockMetadataCatalogComponent)
241-
).componentInstance
242228
})
243229
describe('if metadata present', () => {
244230
it('shows the full metadata', () => {
@@ -247,12 +233,6 @@ describe('RecordMetadataComponent', () => {
247233
it('shows the metadata contact', () => {
248234
expect(metadataContact.metadata).toHaveProperty('contacts')
249235
})
250-
it('shows the metadata catalog', () => {
251-
expect(sourcesService.getSourceLabel).toBeCalledWith(
252-
SAMPLE_RECORD.extras.catalogUuid
253-
)
254-
expect(catalogComponent.sourceLabel).toEqual('catalog label')
255-
})
256236
})
257237
describe('if metadata not present', () => {
258238
beforeEach(() => {
@@ -271,11 +251,6 @@ describe('RecordMetadataComponent', () => {
271251
fixture.debugElement.query(By.directive(MockMetadataContactComponent))
272252
).toBeFalsy()
273253
})
274-
it('does not display the metadata catalog component', () => {
275-
expect(
276-
fixture.debugElement.query(By.directive(MockMetadataCatalogComponent))
277-
).toBeFalsy()
278-
})
279254
it('does not display the image overlay preview', () => {
280255
expect(
281256
fixture.debugElement.query(

libs/ui/elements/src/index.ts

+8-1
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,11 @@
1+
export * from './lib/ui-elements.module'
2+
export * from './lib/metadata-info/metadata-info.component'
3+
export * from './lib/metadata-contact/metadata-contact.component'
4+
export * from './lib/metadata-quality/metadata-quality.component'
5+
export * from './lib/metadata-quality-item/metadata-quality-item.component'
6+
export * from './lib/thumbnail/thumbnail.component'
7+
export * from './lib/content-ghost/content-ghost.component'
8+
export * from './lib/pagination-buttons/pagination-buttons.component'
19
export * from './lib/api-card/api-card.component'
210
export * from './lib/avatar/avatar.component'
311
export * from './lib/content-ghost/content-ghost.component'
@@ -8,7 +16,6 @@ export * from './lib/link-card/link-card.component'
816
export * from './lib/markdown-editor/markdown-editor.component'
917
export * from './lib/markdown-parser/markdown-parser.component'
1018
export * from './lib/max-lines/max-lines.component'
11-
export * from './lib/metadata-catalog/metadata-catalog.component'
1219
export * from './lib/metadata-contact/metadata-contact.component'
1320
export * from './lib/metadata-info/metadata-info.component'
1421
export * from './lib/metadata-quality-item/metadata-quality-item.component'

libs/ui/elements/src/lib/metadata-catalog/metadata-catalog.component.css

Whitespace-only changes.

libs/ui/elements/src/lib/metadata-catalog/metadata-catalog.component.html

-8
This file was deleted.

libs/ui/elements/src/lib/metadata-catalog/metadata-catalog.component.spec.ts

-36
This file was deleted.

libs/ui/elements/src/lib/metadata-catalog/metadata-catalog.component.ts

-11
This file was deleted.

libs/ui/elements/src/lib/ui-elements.module.ts

-3
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@ import { UiLayoutModule } from '@geonetwork-ui/ui/layout'
1414
import { TranslateModule } from '@ngx-translate/core'
1515
import { RelatedRecordCardComponent } from './related-record-card/related-record-card.component'
1616
import { MetadataContactComponent } from './metadata-contact/metadata-contact.component'
17-
import { MetadataCatalogComponent } from './metadata-catalog/metadata-catalog.component'
1817
import { MetadataQualityComponent } from './metadata-quality/metadata-quality.component'
1918
import { MetadataQualityItemComponent } from './metadata-quality-item/metadata-quality-item.component'
2019
import { ErrorComponent } from './error/error.component'
@@ -59,7 +58,6 @@ import { TimeSincePipe } from './user-feedback-item/time-since.pipe'
5958
ApiCardComponent,
6059
RelatedRecordCardComponent,
6160
MetadataContactComponent,
62-
MetadataCatalogComponent,
6361
MetadataQualityComponent,
6462
MetadataQualityItemComponent,
6563
ErrorComponent,
@@ -81,7 +79,6 @@ import { TimeSincePipe } from './user-feedback-item/time-since.pipe'
8179
ApiCardComponent,
8280
RelatedRecordCardComponent,
8381
MetadataContactComponent,
84-
MetadataCatalogComponent,
8582
MetadataQualityComponent,
8683
MetadataQualityItemComponent,
8784
ErrorComponent,

0 commit comments

Comments
 (0)