Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possibly one of the worst python code I have seen in my life #11

Open
Pipe-Runner opened this issue Nov 5, 2022 · 1 comment
Open

Comments

@Pipe-Runner
Copy link

Pipe-Runner commented Nov 5, 2022

  • Poorly commented code
  • Awful code, can't stress this enough. Really awful code.
  • Horribly inefficient because of the use of for loops even though numpy has been imported. But numpy has only been used for random number generation. 🤦🏼
@Pipe-Runner Pipe-Runner closed this as not planned Won't fix, can't repro, duplicate, stale Nov 5, 2022
@Pipe-Runner Pipe-Runner reopened this Nov 5, 2022
@firefly-cpp
Copy link
Contributor

@Pipe-Runner, thank you very much for your critics. Critics are always significant since they contribute to a
better product or process. Since this piece of code was just more or less a translation of the BA algorithm from
Matlab, to have it for comparisons (no major update since its creation back in 2015), I am not interested in undertaking work and making any specific changes. Anyway, the BA has also been included in the NiaPy framework, and I hope you will have a
better first insight when watching a code: Link.

To maintain a spirit of open-source software development, I expect you to incorporate your fixes into this
source code to make this code more beautiful, more efficient, and more commented. Thank you for your time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants