Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PartOf Examples #358

Closed
VitalijTetervov opened this issue Oct 18, 2024 · 1 comment · Fixed by #359
Closed

PartOf Examples #358

VitalijTetervov opened this issue Oct 18, 2024 · 1 comment · Fixed by #359
Assignees

Comments

@VitalijTetervov
Copy link

The last example describing window in PartOf Facet table (https://github.com/buildingSMART/IDS/blob/development/Documentation/UserManual/partof-facet.md) is incorrect.

Applicability Intention
Current: Any window that hosted by a hand wash basin
Possibly change to: Any window that is hosted by a wall

Requirement Intention
Current: The entity (e.g. faucet) must be fixed on a hand wash basin
Possibly change to: A window must be nested in the wall

Facet Definition
Current: Relation="IFCRELNESTS", Entity="IFCSANITARYTERMINAL"
Possibly change to: Relation="IFCRELNESTS", Entity="IFCWALL"

@atomczak
Copy link
Contributor

Nice catch! Actually, the last two rows are duplicated, but only the second mentions wall. I will remove that row, leaving the example with the hand wash basin as it is (just improving the grammar).

@atomczak atomczak self-assigned this Oct 18, 2024
@CBenghi CBenghi linked a pull request Nov 1, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants