Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tolerance documentation 1.0.0 #311

Closed
rubendel opened this issue Jun 4, 2024 · 7 comments
Closed

Tolerance documentation 1.0.0 #311

rubendel opened this issue Jun 4, 2024 · 7 comments
Labels
documentation Improvements or additions to documentation

Comments

@rubendel
Copy link
Contributor

rubendel commented Jun 4, 2024

With #294 closed and IDS version now at 1.0.0, can we assume the documentation to be final? https://github.com/buildingSMART/IDS/blob/development/Documentation/developer-guide.md#precision

With this implemented I am getting quite a lot of failed test cases

@aothms
Copy link

aothms commented Jun 4, 2024

I think #294 wasn't supposed to be closed. The bit of documentation you referenced misses the abs() part, so doesn't properly handle negative values. See https://github.com/buildingSMART/IDS/blob/0d50fd8f2dbd5b388f6fafb67da255cc3ce2b4ca/Documentation/tolerance.md

@CBenghi
Copy link
Contributor

CBenghi commented Jun 4, 2024

Hello Ruben,
not quite yet, the vote held by the panel ratified the schema.
We are still working with the IDS development group to complete the test case documentation.
My personal view is that this will eventually result in a robust implementation across all platform, and I hope that a certification process will guarantee such coherence for all implementers.
I'm hoping to complete this step before the end of the month. I welcome all feedback on test-cases and I'm available for any conversation or one-to-one that might help implementers.
Best,
Claudio

@berlotti
Copy link
Member

berlotti commented Jun 4, 2024

The issue closed automatically when merging the pull request.
Had to process all PRs due to the change in default branche.
Let's indeed take some time to properly document this (and update Audit tool as well)

@rubendel
Copy link
Contributor Author

rubendel commented Jun 4, 2024

@aothms Ah thanks Thomas, I did see a reference to the mentioned document, but it does not exist in the development branch. Nice work, don't understand much of math symbols, but adding abs I can :). @CBenghi Ok that's clear, I'll report whatever I find.

@giuseppeverduciALMA
Copy link
Contributor

@rubendel sorry, by mistake, I closed this PR while synchronizing the IDS repository...
@CBenghi, could you directly add the file on the development branch?

@atomczak
Copy link
Contributor

The tolerance.md file is now added to the development (#317).

atomczak added a commit that referenced this issue Jun 10, 2024
Documenting the group decision, that there should be no tolerance for ranges
#311, #315
@atomczak
Copy link
Contributor

please confirm if this can be closed now @rubendel @CBenghi

@atomczak atomczak added documentation Improvements or additions to documentation review labels Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

6 participants