Trace path traversal in Windows directory removal

To give better error messages for which file or directory operation
fails.

Author: Nils Wireklint

pkg/filesystem/BUILD.bazel

@@ -51,6 +51,7 @@ go_library(
         ],
         "@rules_go//go/platform:windows": [
             "//pkg/filesystem/windowsext",
+            "//pkg/util",
             "@org_golang_google_grpc//codes",
             "@org_golang_google_grpc//status",
             "@org_golang_x_sys//windows",

pkg/filesystem/local_directory_windows.go

@@ -16,6 +16,7 @@ import (
 
 	"github.com/buildbarn/bb-storage/pkg/filesystem/path"
 	"github.com/buildbarn/bb-storage/pkg/filesystem/windowsext"
+	"github.com/buildbarn/bb-storage/pkg/util"
 
 	"golang.org/x/sys/windows"
 	"google.golang.org/grpc/codes"
@@ -586,32 +587,37 @@ func (d *localDirectory) Remove(name path.Component) error {
 
 // On NTFS mount point is a reparse point, no need to unmount.
 func (d *localDirectory) RemoveAllChildren() error {
+	return d.removeAllChildren(nil)
+}
+
+func (d *localDirectory) removeAllChildren(dPath *path.Trace) error {
 	defer runtime.KeepAlive(d)
 
 	names, err := readdirnames(d.handle)
 	if err != nil {
-		return err
+		return util.StatusWrapf(err, "Failed to read contents of directory %#v", dPath.GetUNIXString())
 	}
 	for _, name := range names {
 		component := path.MustNewComponent(name)
 		fileType, err := d.lstat(component)
+		childPath := dPath.Append(component)
 		if err != nil {
-			return err
+			return util.StatusWrapf(err, "Failed to stat %#v", childPath.GetUNIXString())
 		}
 		if fileType == FileTypeDirectory {
 			subdirectory, err := d.enter(component, true)
 			if err != nil {
-				return err
+				return util.StatusWrapf(err, "Failed to enter directory %#v", childPath.GetUNIXString())
 			}
-			err = subdirectory.RemoveAllChildren()
+			err = subdirectory.removeAllChildren(childPath)
 			subdirectory.Close()
 			if err != nil {
 				return err
 			}
 		}
 		err = d.Remove(component)
 		if err != nil {
-			return err
+			return util.StatusWrapf(err, "Failed to remove %#v", childPath.GetUNIXString())
 		}
 	}
 	return nil