Skip to content

Commit 16a2db0

Browse files
committed
Add grpcClientFactory to grpc.NewAuthenticatorFromConfiguration
1 parent 913268b commit 16a2db0

File tree

4 files changed

+7
-5
lines changed

4 files changed

+7
-5
lines changed

cmd/bb_replicator/main.go

+1
Original file line numberDiff line numberDiff line change
@@ -65,6 +65,7 @@ func main() {
6565
replicator_pb.RegisterReplicatorServer(s, replication.NewReplicatorServer(replicator))
6666
},
6767
siblingsGroup,
68+
grpcClientFactory,
6869
); err != nil {
6970
return util.StatusWrap(err, "gRPC server failure")
7071
}

cmd/bb_storage/main.go

+1
Original file line numberDiff line numberDiff line change
@@ -211,6 +211,7 @@ func main() {
211211
}
212212
},
213213
siblingsGroup,
214+
grpcClientFactory,
214215
); err != nil {
215216
return util.StatusWrap(err, "gRPC server failure")
216217
}

pkg/grpc/authenticator.go

+3-3
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ type Authenticator interface {
2525

2626
// NewAuthenticatorFromConfiguration creates a tree of Authenticator
2727
// objects based on a configuration file.
28-
func NewAuthenticatorFromConfiguration(policy *configuration.AuthenticationPolicy, group program.Group) (Authenticator, bool, bool, error) {
28+
func NewAuthenticatorFromConfiguration(policy *configuration.AuthenticationPolicy, group program.Group, grpcClientFactory ClientFactory) (Authenticator, bool, bool, error) {
2929
if policy == nil {
3030
return nil, false, false, status.Error(codes.InvalidArgument, "Authentication policy not specified")
3131
}
@@ -41,7 +41,7 @@ func NewAuthenticatorFromConfiguration(policy *configuration.AuthenticationPolic
4141
needsPeerTransportCredentials := false
4242
requestTLSClientCertificate := false
4343
for _, childConfiguration := range policyKind.Any.Policies {
44-
child, childNeedsPeerTransportCredentials, childRequestTLSClientCertificate, err := NewAuthenticatorFromConfiguration(childConfiguration, group)
44+
child, childNeedsPeerTransportCredentials, childRequestTLSClientCertificate, err := NewAuthenticatorFromConfiguration(childConfiguration, group, grpcClientFactory)
4545
if err != nil {
4646
return nil, false, false, err
4747
}
@@ -55,7 +55,7 @@ func NewAuthenticatorFromConfiguration(policy *configuration.AuthenticationPolic
5555
needsPeerTransportCredentials := false
5656
requestTLSClientCertificate := false
5757
for _, childConfiguration := range policyKind.All.Policies {
58-
child, childNeedsPeerTransportCredentials, childRequestTLSClientCertificate, err := NewAuthenticatorFromConfiguration(childConfiguration, group)
58+
child, childNeedsPeerTransportCredentials, childRequestTLSClientCertificate, err := NewAuthenticatorFromConfiguration(childConfiguration, group, grpcClientFactory)
5959
if err != nil {
6060
return nil, false, false, err
6161
}

pkg/grpc/server.go

+2-2
Original file line numberDiff line numberDiff line change
@@ -33,10 +33,10 @@ func init() {
3333
// based on a configuration stored in a list of Protobuf messages. It
3434
// then lets all of these gRPC servers listen on the network addresses
3535
// of UNIX socket paths provided.
36-
func NewServersFromConfigurationAndServe(configurations []*configuration.ServerConfiguration, registrationFunc func(grpc.ServiceRegistrar), group program.Group) error {
36+
func NewServersFromConfigurationAndServe(configurations []*configuration.ServerConfiguration, registrationFunc func(grpc.ServiceRegistrar), group program.Group, grpcClientFactory ClientFactory) error {
3737
for _, configuration := range configurations {
3838
// Create an authenticator for requests.
39-
authenticator, needsPeerTransportCredentials, requestTLSClientCertificate, err := NewAuthenticatorFromConfiguration(configuration.AuthenticationPolicy, group)
39+
authenticator, needsPeerTransportCredentials, requestTLSClientCertificate, err := NewAuthenticatorFromConfiguration(configuration.AuthenticationPolicy, group, grpcClientFactory)
4040
if err != nil {
4141
return err
4242
}

0 commit comments

Comments
 (0)