Skip to content

Commit 20c222c

Browse files
committed
Fix panic for unimplemented ApplyGetContainingDigests
bb-storage refactored VirtualApply() of ApplyGetContainingDigests to return false instead of an empty set. This was done in bb-remote-execution commit 4983b382e9b368ae4212e78ad861ddaa626d1002: "Remove bogus implementations of ApplyGetContainingDigests".
1 parent f20cf2c commit 20c222c

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

pkg/filesystem/virtual/bazel_output_service_directory.go

+3-1
Original file line numberDiff line numberDiff line change
@@ -184,7 +184,9 @@ func (d *BazelOutputServiceDirectory) filterMissingChildren(ctx context.Context,
184184
// this file or directory depends.
185185
var p virtual.ApplyGetContainingDigests
186186
if !node.GetNode().VirtualApply(&p) {
187-
panic("output path contains nodes that don't support ApplyGetContainingDigests")
187+
// This node type does not depend on any digests, e.g. a file in the
188+
// file pool.
189+
return true
188190
}
189191
if p.Err != nil {
190192
// Can't compute the set of digests underneath

0 commit comments

Comments
 (0)