Resolve some linting

Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>

Author: peterzhuamazon

.eslintrc.js

@@ -27,6 +27,6 @@ module.exports = {
     'max-classes-per-file': 'off',
     'no-new': 'off',
     "no-console": "off",
-    'max-len': ['error', { code: 120, ignoreComments: true }],
+    'max-len': ['error', { code: 160, ignoreComments: true }],
   },
 };

.prettierrc

@@ -1,5 +1,5 @@
 {
-  "printWidth": 100,
+  "printWidth": 160,
   "tabWidth": 2,
   "useTabs": false,
   "semi": true,

package.json

@@ -18,7 +18,7 @@
     "start": "npm run clean && npm run build && probot run ./bin/app.js",
     "clean": "rm -rf ./bin/*",
     "format": "prettier --write \"src/**/*.{js,ts}\" \"test/**/*.ts\" \"configs/**/*.{yaml,yml}\"",
-    "lint": "eslint --fix \"src/**/*.ts\" \"test/**/*.ts\" --ignore-pattern \"**/*.d.ts\"",
+    "lint": "eslint --fix \"src/**/*.ts\" --ignore-pattern \"**/*.d.ts\"",
     "test": "jest"
   },
   "dependencies": {

src/app.ts

@@ -6,11 +6,7 @@ export default async (app: Probot) => {
   app.log.info('OpenSearch Automation App is starting now......');
 
   const srvObj = new Service('Hello World Service');
-  await srvObj.initService(
-    'configs/resources/peterzhu-organization.yml',
-    'configs/operations/hello-world.yml',
-    app,
-  );
+  await srvObj.initService('configs/resources/peterzhu-organization.yml', 'configs/operations/hello-world.yml', app);
   await srvObj.registerEvents();
 
   app.log.info('All objects initialized, start listening events......');

src/call/create-issue-comment.ts

@@ -12,20 +12,12 @@ export interface CreateIssueCommentParams {
   tagUser?: string;
 }
 
-export default async function createIssueComment(
-  app: Probot,
-  context: any,
-  { text }: CreateIssueCommentParams,
-): Promise<void> {
+export default async function createIssueComment(app: Probot, context: any, { text }: CreateIssueCommentParams): Promise<void> {
   const comment = context.issue({ body: dedent`${text}` });
   context.octokit.issues.createComment(comment);
 }
 
-export async function createIssueCommentTagUser(
-  app: Probot,
-  context: any,
-  { text, tagUser }: CreateIssueCommentParams,
-): Promise<void> {
+export async function createIssueCommentTagUser(app: Probot, context: any, { text, tagUser }: CreateIssueCommentParams): Promise<void> {
   const comment = context.issue({ body: dedent`@${tagUser}: ${text}` });
   context.octokit.issues.createComment(comment);
 }

src/call/print-to-console.ts

@@ -9,10 +9,6 @@ export interface PrintToConsoleParams {
   text: string;
 }
 
-export default async function printToConsole(
-  app: Probot,
-  context: any,
-  { text }: PrintToConsoleParams,
-): Promise<void> {
+export default async function printToConsole(app: Probot, context: any, { text }: PrintToConsoleParams): Promise<void> {
   app.log.info(text);
 }

src/config/resource-config.ts

@@ -105,11 +105,7 @@ export class ResourceConfig extends Config {
   private async __initOrganizations(): Promise<Map<string, Organization>> {
     const orgObjMap = new Map<string, Organization>();
     for (const orgData of (this.configData as ResourceData).organizations) {
-      const orgObj = new Organization(
-        orgData.name,
-        await this.__initProjects(orgData),
-        await this.__initRepositories(orgData),
-      );
+      const orgObj = new Organization(orgData.name, await this.__initProjects(orgData), await this.__initRepositories(orgData));
       await orgObj.setContext(this.octokit);
       orgObjMap.set(orgData.name, orgObj);
     }

src/service/operation/task.ts

@@ -15,7 +15,10 @@ export class Task {
     this.callFunc = callArray[1];
     this.callArgs = callArgs;
     const randomString = require('randomstring');
-    const namePostfix = randomString.generate({ length: 8, charset: 'alphanumeric' });
+    const namePostfix = randomString.generate({
+      length: 8,
+      charset: 'alphanumeric',
+    });
     this.name = name ? `${name}#${namePostfix}` : `${this.callName}#${namePostfix}`;
   }
 

src/service/resource/issue.ts

@@ -30,9 +30,7 @@ export class Issue extends Entity {
           repo: this.repositoryName,
           pull_number: this.issueNumber,
         });
-        console.log(
-          `Set issue context: ${this.orgName}/${this.repositoryName}#${this.issueNumber}`,
-        );
+        console.log(`Set issue context: ${this.orgName}/${this.repositoryName}#${this.issueNumber}`);
       }
       this.nodeId = this.context.data.node_id;
     } catch (e) {

src/service/resource/project-field.ts

@@ -55,21 +55,21 @@ export class ProjectField extends Entity {
         }
       `;
       const allFieldContextArray: any = await octokit.graphql(projFieldQuery);
-      console.log(
-        `Set projectfield context: ${this.orgName}/project/${this.projectNumber}/field/${this.fieldName}`,
-      );
+      console.log(`Set projectfield context: ${this.orgName}/project/${this.projectNumber}/field/${this.fieldName}`);
 
       // There are total of 5 datatypes for GitHub Project Fields
       // The ProjectV2Field map to TEXT NUMBER DATE
       // While ProjectV2IterationField map to ITERATION, and ProjectV2SingleSelectField map to SINGLE_SELECT
-      for (const fieldContext of allFieldContextArray.node.fields.nodes) {
-        if (this.fieldName === fieldContext.name) {
-          this.nodeId = fieldContext.id;
-          this.fieldType = fieldContext.dataType;
-          this.context = fieldContext;
-          break;
-        }
+
+      const fieldContext = allFieldContextArray.node.fields.nodes.find((field: Record<string, string>) => field.name === this.fieldName);
+
+      if (!fieldContext) {
+        throw new Error(`${this.fieldName} not found! Please check organization ${this.orgName} project ${this.projectNumber} and verify that field exist.`);
       }
+
+      this.nodeId = fieldContext.id;
+      this.fieldType = fieldContext.dataType;
+      this.context = fieldContext;
     } catch (e) {
       console.error(`ERROR: ${e}`);
     }

src/service/service.ts

@@ -32,11 +32,7 @@ export class Service {
     return this.operation;
   }
 
-  public async initService(
-    resourceConfigPath: string,
-    operationConfigPath: string,
-    app: Probot,
-  ): Promise<void> {
+  public async initService(resourceConfigPath: string, operationConfigPath: string, app: Probot): Promise<void> {
     app.log.info(`Initializing Service: ${this.name} `);
     // Get octokit client so Resource object will get context
     const octokit = await octokitAuth(app, Number(process.env.INSTALLATION_ID));
@@ -81,9 +77,7 @@ export class Service {
               if (typeof callFuncCustom === 'function') {
                 await callFuncCustom(this.app, context, { ...callArgs });
               } else {
-                throw new Error(
-                  `${callFuncCustom} is not a function, please verify in ${callPath}`,
-                );
+                throw new Error(`${callFuncCustom} is not a function, please verify in ${callPath}`);
               }
             }
           }

test/index.test.ts

@@ -18,9 +18,7 @@ const issueCreatedBody = { body: 'Thanks for opening this issue!' };
 
 const privateKey = fs.readFileSync(path.join(__dirname, 'fixtures/mock-cert.pem'), 'utf-8');
 
-const payload = JSON.parse(
-  fs.readFileSync(path.join(__dirname, 'fixtures/issues.opened.json'), 'utf-8'),
-);
+const payload = JSON.parse(fs.readFileSync(path.join(__dirname, 'fixtures/issues.opened.json'), 'utf-8'));
 
 describe('My Probot app', () => {
   let probot: any;