Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSS output is broken #46

Open
rosswintle opened this issue Mar 16, 2021 · 1 comment
Open

CSS output is broken #46

rosswintle opened this issue Mar 16, 2021 · 1 comment

Comments

@rosswintle
Copy link

I've opened a support conversation on wordpress.org for this (currently pending moderation) but I believe that the CSS output is broken in version 1.3.

It generates:

src: url(<url1>) format(<format1>);
src: url(<url2>) format(<format2>);

when it should generate:

src: url(<url1>) format(<format1), url(<url2) format(<format2>);

I think the fix is to change the loop on line 359 of classes/class-bsf-custom-fonts-render.php to:

$font_face_css .= 'src: ';
$font_face_css .= implode(',', $value);
@rosswintle
Copy link
Author

Here's my related support conversation on wordpress.org:

https://wordpress.org/support/topic/version-1-3-breaks-custom-fonts/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant