Skip to content

Commit 3fe020a

Browse files
authored
Fixed continuous log message of telemetry docker image not present. (sonic-net#21647)
Fixes: sonic-net#19352. Sequence when we upgrade using config db from older Image that has Telemetry docker feature enabled. Older Image has Telemetry docker image and telemetry feature is enable Newer Image does not have Telemetry docker image but feature is enable [because of old image config db] Container checker will check for telemetry image and log the invalid error message periodically. How I fixed: As mentioned in this PR sonic-net#18529 in newer image it is expected to have Telemetry feature in enable state but with no docker image. [Basically feature is implicitly disable] . So I have removed the print message as not needed. Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
1 parent ff21fc1 commit 3fe020a

File tree

1 file changed

+1
-2
lines changed

1 file changed

+1
-2
lines changed

files/image_config/monit/container_checker

+1-2
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,6 @@ def check_docker_image(image_name):
3535
DOCKER_CLIENT.images.get(image_name)
3636
return True
3737
except (docker.errors.ImageNotFound, docker.errors.APIError) as err:
38-
print("Failed to get image '{}'. Error: '{}'".format(image_name, err))
3938
return False
4039

4140
def get_expected_running_containers():
@@ -79,7 +78,7 @@ def get_expected_running_containers():
7978
# if gnmi container image is present, check gnmi container instead of telemetry
8079
ret = check_docker_image("docker-sonic-gnmi")
8180
if not ret:
82-
print("Ignoring telemetry container check on image which has no corresponding docker image")
81+
print("Ignoring telemetry container check on image which has no corresponding telemetry or gnmi docker image")
8382
else:
8483
container_list.append("gnmi")
8584
continue

0 commit comments

Comments
 (0)