-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for Capybara 3.x #45
Comments
Do you have a fork I could use or refer to for how to do this? Thanks. |
Slightly related to this; If you have this in your Gemfile: gem 'minitest-rails-capybara'
gem 'capybara' (without specifying versions) and do a I don't know what the correct solution is here. |
@jrmhaig That sounds more like an issue with Bundler than with this gem to me. @MrHubble Sure, here's my fork: https://github.com/krautcomputing/minitest-rails-capybara/tree/2.x_with_capybara_3 |
Yes and no. Bundler will try to find the most recent version of all gems that satisfy all dependencies. It is therefore possible, according to the definitions of the gems, to upgrade By the way, I hope I am not coming across as being awkward or argumentative. I very much appreciate the work that has gone into this gem and I do not think this is a major problem. However, I thought it was worth pointing out as some users may encounter problems as a result. |
Perhaps this gem is no longer actively maintained because Rails 5.1 has system tests (with Capybara) baked in? I believe the author of The Minitest Cookbook uses the default system tests setup:
https://chriskottom.com/blog/2017/04/full-stack-testing-with-rails-system-tests/ |
Ah, good to know! |
@manuelmeurer, I'm currently using your fork to support capybara 3 with Rails 4.2. Thanks! |
@CyborgMaster Glad it works for you! 😄 |
Hey, thanks for writing this fantastic gem! 😄
Are there any plans to support Capybara v3? I tried simply updating the dependency (und patching
minitest-capybara
to support Capybara v3 as well) and it worked fine.If you could point me into the right direction to what would need to be done to support Cabybara v3, I'd be happy to work on it!
The text was updated successfully, but these errors were encountered: