Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config leak between multiple zed windows #70

Open
Marcisbee opened this issue Feb 14, 2025 · 4 comments
Open

Config leak between multiple zed windows #70

Marcisbee opened this issue Feb 14, 2025 · 4 comments

Comments

@Marcisbee
Copy link

I have multiple projects and I tend to open them multiple of them at once in separate zed windows. All of them have biome.json, but some of them have different formatting settings. And I noticed that one project formatting settings leak into other zed window where formatting should be different (talking about line width and quote type).

When I open zed windows one project at a time, then everything works as expected.

@dyc3
Copy link

dyc3 commented Feb 14, 2025

multiple of them at once in separate zed windows.

So we can try to reproduce this, how exactly are you doing this?

@Marcisbee
Copy link
Author

Project A:

  • biome.json:
{
  "javascript": {
    "formatter": {
      "enabled": true,
      "quoteStyle": "double"
    }
  }
}
  • index.js:
const hello = "world 1";

Project B:

  • biome.json:
{
  "javascript": {
    "formatter": {
      "enabled": true,
      "quoteStyle": "single"
    }
  }
}
  • index.js:
const hello = "world 2";

Now open both projects with zed in separate windows. Try to apply formatting to index.js. Both projects format to the same config.

These are my zed settings regarding biome:

{
  "lsp": {
    "biome": {
      "settings": {
        "require_config_file": true
      }
    }
  },
  "code_actions_on_format": {
    "source.fixAll.biome": true,
    "source.organizeImports.biome": true
  }
}

@dyc3
Copy link

dyc3 commented Feb 14, 2025

Would you mind putting all this into a repo? You can use our tool npm create @biomejs/biome-reproduction.

And how are you opening zed? Are you just running zed . in these folders or are you opening zed and then opening the projects via the ui?

@Marcisbee
Copy link
Author

Here's a minimal reproduction repo: https://github.com/Marcisbee/zed-repro-1

Readme contains all the steps needed to repdouce this.

I'm on latest zed version as of now Zed 0.174.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants