Skip to content

Commit 4437b48

Browse files
majetideepakfacebook-github-bot
authored andcommitted
build(ci): Use ccache instead of .ccache (facebookincubator#11893)
Summary: Jacob mentioned that files with the dot prefix are restricted from being uploaded and hence the ccache is disabled. Pull Request resolved: facebookincubator#11893 Reviewed By: Yuhta Differential Revision: D67771145 Pulled By: kgpai fbshipit-source-id: bda06c15150b27d381d774fce2531da6a74fb9a1
1 parent cd6431a commit 4437b48

File tree

6 files changed

+23
-23
lines changed

6 files changed

+23
-23
lines changed

.github/workflows/benchmark.yml

+3-3
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ jobs:
4343
if: github.repository == 'facebookincubator/velox'
4444
runs-on: 8-core-ubuntu
4545
env:
46-
CCACHE_DIR: "${{ github.workspace }}/.ccache/"
46+
CCACHE_DIR: "${{ github.workspace }}/ccache/"
4747
CCACHE_BASEDIR: "${{ github.workspace }}"
4848
BINARY_DIR: "${{ github.workspace }}/benchmarks/"
4949
LINUX_DISTRO: "ubuntu"
@@ -56,7 +56,7 @@ jobs:
5656
uses: actions/cache/restore@v3
5757
id: restore-cache
5858
with:
59-
path: ".ccache"
59+
path: "ccache"
6060
key: ccache-benchmark-${{ github.sha }}
6161
restore-keys: |
6262
ccache-benchmark-
@@ -132,7 +132,7 @@ jobs:
132132
uses: actions/cache/save@v3
133133
id: cache
134134
with:
135-
path: ".ccache"
135+
path: "ccache"
136136
key: ccache-benchmark-${{ github.sha }}
137137

138138
- name: "Install benchmark dependencies"

.github/workflows/build_pyvelox.yml

+8-8
Original file line numberDiff line numberDiff line change
@@ -90,12 +90,12 @@ jobs:
9090
# NEXT_VERSION=$(echo $VERSION | awk -F. -v OFS=. '{$NF++ ; print}')
9191
echo "build_version=${VERSION}a${COMMITS_SINCE_TAG}" >> $GITHUB_OUTPUT
9292
93-
- run: mkdir -p .ccache
93+
- run: mkdir -p ccache
9494
- name: "Restore ccache"
9595
uses: actions/cache/restore@v3
9696
id: restore-cache
9797
with:
98-
path: ".ccache"
98+
path: "ccache"
9999
key: ccache-wheels-${{ matrix.os }}-${{ github.sha }}
100100
restore-keys: |
101101
ccache-wheels-${{ matrix.os }}-
@@ -126,28 +126,28 @@ jobs:
126126
CIBW_MANYLINUX_X86_64_IMAGE: "ghcr.io/facebookincubator/velox-dev:torcharrow-avx"
127127
CIBW_BEFORE_ALL_LINUX: >
128128
mkdir -p /output &&
129-
cp -R /host${{ github.workspace }}/.ccache /output/.ccache &&
129+
cp -R /host${{ github.workspace }}/ccache /output/ccache &&
130130
ccache -s
131131
CIBW_ENVIRONMENT_PASS_LINUX: CCACHE_DIR BUILD_VERSION
132132
CIBW_TEST_EXTRAS: "tests"
133133
CIBW_TEST_COMMAND: "cd {project}/pyvelox && python -m unittest -v"
134134
CIBW_TEST_SKIP: "*macos*"
135-
CCACHE_DIR: "${{ matrix.os != 'macos-11' && '/output' || github.workspace }}/.ccache"
135+
CCACHE_DIR: "${{ matrix.os != 'macos-11' && '/output' || github.workspace }}/ccache"
136136
BUILD_VERSION: "${{ inputs.version || steps.version.outputs.build_version }}"
137137
with:
138138
output-dir: wheelhouse
139139

140-
- name: "Move .ccache to workspace"
140+
- name: "Move ccache to workspace"
141141
if: matrix.os != 'macos-11'
142142
run: |
143-
mkdir -p .ccache
144-
cp -R ./wheelhouse/.ccache/* .ccache
143+
mkdir -p ccache
144+
cp -R ./wheelhouse/ccache/* ccache
145145
146146
- name: "Save ccache"
147147
uses: actions/cache/save@v3
148148
id: cache
149149
with:
150-
path: ".ccache"
150+
path: "ccache"
151151
key: ccache-wheels-${{ matrix.os }}-${{ github.sha }}
152152

153153
- name: "Rename wheel compatibility tag"

.github/workflows/experimental.yml

+2-2
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ jobs:
5050
runs-on: 16-core-ubuntu
5151
timeout-minutes: 120
5252
env:
53-
CCACHE_DIR: "${{ github.workspace }}/.ccache/"
53+
CCACHE_DIR: "${{ github.workspace }}/ccache/"
5454
LINUX_DISTRO: "ubuntu"
5555
steps:
5656

@@ -114,7 +114,7 @@ jobs:
114114
container: ghcr.io/facebookincubator/velox-dev:presto-java
115115
timeout-minutes: 120
116116
env:
117-
CCACHE_DIR: "${{ github.workspace }}/.ccache/"
117+
CCACHE_DIR: "${{ github.workspace }}/ccache/"
118118
LINUX_DISTRO: "centos"
119119
steps:
120120

.github/workflows/linux-build-base.yml

+2-2
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ jobs:
3434
run:
3535
shell: bash
3636
env:
37-
CCACHE_DIR: "${{ github.workspace }}/.ccache"
37+
CCACHE_DIR: "${{ github.workspace }}/ccache"
3838
VELOX_DEPENDENCY_SOURCE: SYSTEM
3939
GTest_SOURCE: BUNDLED
4040
simdjson_SOURCE: BUNDLED
@@ -124,7 +124,7 @@ jobs:
124124
if: ${{ github.repository == 'facebookincubator/velox' }}
125125
name: "Ubuntu debug with resolve_dependency"
126126
env:
127-
CCACHE_DIR: "${{ github.workspace }}/.ccache"
127+
CCACHE_DIR: "${{ github.workspace }}/ccache"
128128
USE_CLANG: "${{ inputs.use-clang && 'true' || 'false' }}"
129129
defaults:
130130
run:

.github/workflows/macos.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ jobs:
5353
os: [macos-13, macos-14]
5454
runs-on: ${{ matrix.os }}
5555
env:
56-
CCACHE_DIR: '${{ github.workspace }}/.ccache'
56+
CCACHE_DIR: '${{ github.workspace }}/ccache'
5757
# The arm runners have only 7GB RAM
5858
BUILD_TYPE: "${{ matrix.os == 'macos-14' && 'Release' || 'Debug' }}"
5959
INSTALL_PREFIX: "/tmp/deps-install"

.github/workflows/scheduled.yml

+7-7
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,7 @@ jobs:
9292
container: ghcr.io/facebookincubator/velox-dev:centos9
9393
timeout-minutes: 120
9494
env:
95-
CCACHE_DIR: "${{ github.workspace }}/.ccache"
95+
CCACHE_DIR: "${{ github.workspace }}/ccache"
9696
LINUX_DISTRO: "ubuntu"
9797
MAKEFLAGS: "NUM_THREADS=${{ inputs.numThreads || 16 }} MAX_HIGH_MEM_JOBS=${{ inputs.maxHighMemJobs || 8 }} MAX_LINK_JOBS=${{ inputs.maxLinkJobs || 4 }}"
9898

@@ -590,7 +590,7 @@ jobs:
590590
needs: compile
591591
timeout-minutes: 120
592592
env:
593-
CCACHE_DIR: "${{ github.workspace }}/.ccache/"
593+
CCACHE_DIR: "${{ github.workspace }}/ccache/"
594594
LINUX_DISTRO: "centos"
595595
steps:
596596

@@ -755,7 +755,7 @@ jobs:
755755
container: ghcr.io/facebookincubator/velox-dev:presto-java
756756
timeout-minutes: 120
757757
env:
758-
CCACHE_DIR: "${{ github.workspace }}/.ccache/"
758+
CCACHE_DIR: "${{ github.workspace }}/ccache/"
759759
LINUX_DISTRO: "centos"
760760
steps:
761761

@@ -819,7 +819,7 @@ jobs:
819819
timeout-minutes: 120
820820
if: ${{ needs.compile.outputs.presto_bias == 'true' }}
821821
env:
822-
CCACHE_DIR: "${{ github.workspace }}/.ccache/"
822+
CCACHE_DIR: "${{ github.workspace }}/ccache/"
823823
LINUX_DISTRO: "centos"
824824
steps:
825825

@@ -907,7 +907,7 @@ jobs:
907907
timeout-minutes: 120
908908
if: ${{ needs.compile.outputs.presto_aggregate_bias == 'true' }}
909909
env:
910-
CCACHE_DIR: "${{ github.workspace }}/.ccache/"
910+
CCACHE_DIR: "${{ github.workspace }}/ccache/"
911911
LINUX_DISTRO: "centos"
912912
steps:
913913

@@ -1004,7 +1004,7 @@ jobs:
10041004
container: ghcr.io/facebookincubator/velox-dev:presto-java
10051005
timeout-minutes: 120
10061006
env:
1007-
CCACHE_DIR: "${{ github.workspace }}/.ccache/"
1007+
CCACHE_DIR: "${{ github.workspace }}/ccache/"
10081008
LINUX_DISTRO: "centos"
10091009
steps:
10101010

@@ -1067,7 +1067,7 @@ jobs:
10671067
container: ghcr.io/facebookincubator/velox-dev:presto-java
10681068
timeout-minutes: 120
10691069
env:
1070-
CCACHE_DIR: "${{ github.workspace }}/.ccache/"
1070+
CCACHE_DIR: "${{ github.workspace }}/ccache/"
10711071
LINUX_DISTRO: "centos"
10721072
steps:
10731073

0 commit comments

Comments
 (0)