@@ -35,7 +35,7 @@ permissions:
35
35
36
36
jobs :
37
37
metrics :
38
- name : Linux ${{ matrix.type }} with adapters
38
+ name : Linux ${{ matrix.link-type }} - ${{ matrix. type }} with adapters
39
39
if : ${{ github.repository == 'facebookincubator/velox' }}
40
40
runs-on : ${{ matrix.runner }}
41
41
container : ghcr.io/facebookincubator/velox-dev:adapters
59
59
run : git config --global --add safe.directory ${GITHUB_WORKSPACE}
60
60
61
61
- name : Make ${{ matrix.link-type }} - ${{ matrix.type }} Build
62
- if : ${{ matrix.link-type == 'static' }}
63
62
env :
64
63
MAKEFLAGS : ' MAX_HIGH_MEM_JOBS=8 MAX_LINK_JOBS=4'
65
64
run : |
@@ -73,44 +72,39 @@ jobs:
73
72
"-DVELOX_ENABLE_ABFS=ON"
74
73
"-DVELOX_ENABLE_REMOTE_FUNCTIONS=ON"
75
74
"-DVELOX_MONO_LIBRARY=ON"
75
+ "-DVELOX_BUILD_SHARED=${{ matrix.link-type == 'shared' && 'ON' || 'OFF' }}"
76
76
)
77
- make '${{ matrix.type }}'
78
77
79
- - name : Make ${{ matrix.link-type }} - ${{ matrix.type }} Build
80
- if : ${{ matrix.link-type == 'shared' }}
81
- env :
82
- MAKEFLAGS : ' MAX_HIGH_MEM_JOBS=8 MAX_LINK_JOBS=4'
83
- run : |
84
- EXTRA_CMAKE_FLAGS=(
85
- "-DVELOX_ENABLE_BENCHMARKS=ON"
86
- "-DVELOX_ENABLE_ARROW=ON"
87
- "-DVELOX_ENABLE_PARQUET=ON"
88
- "-DVELOX_ENABLE_HDFS=ON"
89
- "-DVELOX_ENABLE_S3=ON"
90
- "-DVELOX_ENABLE_GCS=ON"
91
- "-DVELOX_ENABLE_ABFS=ON"
92
- "-DVELOX_ENABLE_REMOTE_FUNCTIONS=ON"
93
- "-DVELOX_MONO_LIBRARY=ON"
94
- "-DVELOX_BUILD_SHARED=ON"
95
- )
96
- make '${{ matrix.type }}'
78
+ echo "CMake Flags: ${EXTRA_CMAKE_FLAGS[*]}"
79
+ make '${{ matrix.type }}' EXTRA_CMAKE_FLAGS="${EXTRA_CMAKE_FLAGS[*]}"
97
80
98
81
- name : Log binary sizes
99
82
run : |
100
83
mkdir -p /tmp/metrics
101
84
sizes_file=/tmp/metrics/object_sizes
85
+ echo "sizes_file=$sizes_file" >> $GITHUB_ENV
86
+
102
87
pushd '_build/${{ matrix.type }}'
103
88
104
89
# . to also check in lib for mono build
105
- find . -type f -name 'libvelox*.so' -o -name 'libvelox*.a' -exec ls -l -BB {} \; |
90
+ find . -type f \( -name 'libvelox*.so' -o -name 'libvelox*.a' \) -exec ls -l -BB {} \; |
106
91
awk '{print $5, $9; total += $5} END {print total," total_lib_size"}' > $sizes_file
107
92
108
- find velox -type f -name '*.o' -exec ls -l -BB {} \; |
93
+ find velox -type f -name '*.o' -exec ls -l -BB {} \; |
109
94
awk '{print $5, $9; total += $5} END {print total," total_obj_size"}' >> $sizes_file
110
95
111
96
find velox -type f -name 'velox_*' -exec ls -l -BB {} \; |
112
97
awk '{print $5, $9; total += $5} END {print total," total_exec_size"}' >> $sizes_file
113
98
99
+ echo "::group::Size file for ${{ matrix.link-type }} - ${{ matrix.type }}"
100
+ cat $sizes_file
101
+ echo "::endgroup::"
102
+
103
+ - uses : actions/upload-artifact@v4
104
+ with :
105
+ path : ${{ env.sizes_file }}
106
+ name : " ${{ matrix.type }}-${{ matrix.link-type }}-sizes"
107
+
114
108
- name : Copy ninja_log
115
109
run : cp _build/${{ matrix.type }}/.ninja_log /tmp/metrics/.ninja_log
116
110
0 commit comments