From bd6a7e1cb458c77aeb54550689313e9e829a8e20 Mon Sep 17 00:00:00 2001 From: David Lougheed Date: Mon, 22 Apr 2024 10:59:54 -0400 Subject: [PATCH 1/3] fix: increase proxy buffer size/number for auth perf: increase proxy buffer number for all proxied reqs --- conf/nginx.conf.tpl | 1 + conf/proxy.conf | 3 +++ conf/proxy_large_headers.conf | 5 +++++ 3 files changed, 9 insertions(+) create mode 100644 conf/proxy_large_headers.conf diff --git a/conf/nginx.conf.tpl b/conf/nginx.conf.tpl index 325a0ff..15da2fb 100644 --- a/conf/nginx.conf.tpl +++ b/conf/nginx.conf.tpl @@ -118,6 +118,7 @@ http { location / { # Reverse proxy settings include /gateway/conf/proxy.conf; + include /gateway/conf/proxy_large_headers.conf; # Immediate set/re-use means we don't get resolve errors if not up (as opposed to passing as a literal) set $upstream_auth http://${BENTOV2_AUTH_CONTAINER_NAME}:${BENTOV2_AUTH_INTERNAL_PORT_PLAIN_HTTP}; diff --git a/conf/proxy.conf b/conf/proxy.conf index 3ddc676..c1d30c6 100644 --- a/conf/proxy.conf +++ b/conf/proxy.conf @@ -11,4 +11,7 @@ proxy_set_header X-Forwarded-Proto $scheme; proxy_set_header X-Forwarded-Host $host; proxy_set_header X-Forwarded-For $proxy_add_x_forwarded_for; +# increase size of proxied response for returning larger files +proxy_buffers 64 4k; + proxy_ignore_client_abort on; diff --git a/conf/proxy_large_headers.conf b/conf/proxy_large_headers.conf new file mode 100644 index 0000000..2bfd2b2 --- /dev/null +++ b/conf/proxy_large_headers.conf @@ -0,0 +1,5 @@ +# inspired by https://www.getpagespeed.com/server-setup/nginx/tuning-proxy_buffer_size-in-nginx +# proxy_buffers is set in proxy.conf + +proxy_buffer_size 16k; +proxy_busy_buffers_size 24k; From f34696ad351288139a141dd934d44121887ff35c Mon Sep 17 00:00:00 2001 From: David Lougheed Date: Mon, 22 Apr 2024 11:00:50 -0400 Subject: [PATCH 2/3] wording [no ci] --- conf/proxy.conf | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/conf/proxy.conf b/conf/proxy.conf index c1d30c6..1be5904 100644 --- a/conf/proxy.conf +++ b/conf/proxy.conf @@ -11,7 +11,7 @@ proxy_set_header X-Forwarded-Proto $scheme; proxy_set_header X-Forwarded-Host $host; proxy_set_header X-Forwarded-For $proxy_add_x_forwarded_for; -# increase size of proxied response for returning larger files +# increase size of proxied response for returning larger responses (files, etc.) proxy_buffers 64 4k; proxy_ignore_client_abort on; From 3a0047032ccbffc08e2923d83f6546e8a33df609 Mon Sep 17 00:00:00 2001 From: David Lougheed Date: Tue, 23 Apr 2024 08:13:36 -0400 Subject: [PATCH 3/3] better comment for proxy buffers --- conf/proxy.conf | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/conf/proxy.conf b/conf/proxy.conf index 1be5904..499c428 100644 --- a/conf/proxy.conf +++ b/conf/proxy.conf @@ -11,7 +11,8 @@ proxy_set_header X-Forwarded-Proto $scheme; proxy_set_header X-Forwarded-Host $host; proxy_set_header X-Forwarded-For $proxy_add_x_forwarded_for; -# increase size of proxied response for returning larger responses (files, etc.) +# increase size of response buffers for returning larger responses +# (small-medium files, large JSON responses, etc.) proxy_buffers 64 4k; proxy_ignore_client_abort on;